Why are some pr's not getting created, stuck "pending status checks"

[tjenkinson]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Wanted end result.

PR's with updates should be automatically created once the 7 day stabilityDays has passed.

It looks like sometimes after the 7 days the PR is not created but instead the update gets stuck under "pending status checks" on the dependency dashboard.

E.g. the update for regjsparser on tjenkinson/redos-detector#8

What status check is it waiting for?

Thanks

What you tried so far.

I think I could click the checkbox to create a PR and it would work, but I don't think that should be needed.

I've checked the commit on the branch for regjsparser and there are no pending status checks.

Relevant debug logs

No response

[rarkins]

Because of this: https://github.com/tjenkinson/redos-detector/blob/433378c1387d07a7b6ef964480b8b6ab5babab3d/renovate.json#L5

And you don't have any tests running on branches other than Renovate's own:

You should remove the prCreation setting

[tjenkinson]

Right but if the PR is created immediately, then the auto merge action will also merge it asap meaning things could get merged in before the stability days have passed.

I think I could also make the stability days check renovate adds a required check, but that won't work if the check is not added to none renovate PR's, and also the auto merge action won't work then because it will time out

[tjenkinson]

I think that 24 hour delay used to work and if it did I think this would not be an issue

[tjenkinson]

so IIUC not-pending waits for at least one other non-renovate status check as a way of detecting when CI has started?

Thoughts on having a new when-stable value which would cause the PR to be opened immediately when the stability days have passed?

Otherwise I think a workaround might be that I add another dummy action that always succeeds and runs on the renovate branches

[tjenkinson]

Actually just did a search of the source code and spotted the prNotPendingHours config, so I think setting that to 0 should also work, but might be effected by the same issue that's stopped the 24 delay working.

Will have a look through the logs and see if I can spot what's going on

[tjenkinson]

ok so I checked the logs: https://app.renovatebot.com/dashboard#github/tjenkinson/redos-detector/1053289593

and there was

DEBUG: Branch is 761 hours old - skipping PR creation(branch="renovate/regjsparser-0.x")

coming from

renovate/lib/workers/pr/index.js

Lines 72 to 77 in a3f471e

	if (elapsedHours < config.prNotPendingHours) {
	logger.debug(
	`Branch is ${elapsedHours} hours old - skipping PR creation`
	);
	return null;
	}

So not sure what prNotPendingHours is but it can't be 24. Couldn't see it getting overriden anywhere and also couldn't find anything in the log that printed the entire resolved config so a bit of a mystery.

[tjenkinson]

I solved this by setting the internalChecksAsSuccess option to true :)

[viceice]

not a good idea, better run ci checks

[tjenkinson]

But the problem in this case is we don’t have any ci checks on the branch. They run on prs

[viceice]

then set branch creation immediate and internal filter to strict.

then you get the PR after stability days are passing

[tjenkinson]

An perfect that’s exactly what I wanted. Will give it a go later

[tjenkinson]

The default is strict though so this is what I had originally? #21720 (reply in thread) shows it not opening the pr

[viceice]

without any ci checks it makes no sense to the PR creation to not-pending.

[viceice]

so set it back to default (immediate)

[lapwat]

You can use the :skipStatusChecks preset that will set ignoreTests option to true.

https://docs.renovatebot.com/presets-default/#skipstatuschecks