nuget manager does not respect ignorePaths for quite some time

[konradmalik]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab

Please tell us more about your question or problem

I think there's a bug with handling ignorePaths for nuget manager.

We've been running renovate and a couple months ago (unfortunately, I don't know when exactly, 2-3 months?) renovate started generating MRs for the autogenerated code in our repo, while it was explicitly included in ignorePaths and nothing changed on our end. We always run the newest renovate though, so I suspected the problem is on my end (like some breaking change in config that I didn't notice).

Now I've had some time to sit and investigate, and I have a repro-repo: https://github.com/konradmalik/renovate-nuget-ignore-paths

Note that I only noticed nuget but maybe more manages are impacted. For example: I've never used cake but because it's also in dotnet category, it might be impacted as well. I know that poetry, gitlabci, gitlabci-include for sure work fine (additionally more people would def. notice that).

Clone it, run:

LOG_LEVEL=debug renovate --platform=local --repository-cache=reset

and see that:

DEBUG: Matched 2 file(s) for manager nuget: fail/fail.csproj, pass/pass.csproj (repository=local)

and

DEBUG: packageFiles with updates (repository=local)
       "config": {
         "nuget": [
           {
             "deps": [
               {
                 "datasource": "nuget",
                 "depType": "nuget",
                 "depName": "Moq",
                 "currentValue": "4.18.4",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "4.20.72",
                     "newValue": "4.20.72",
                     "releaseTimestamp": "2024-09-07T01:37:52.233Z",
                     "newMajor": 4,
                     "newMinor": 20,
                     "newPatch": 72,
                     "updateType": "minor",
                     "branchName": "renovate/moq-4.x"
                   }
                 ],
                 "packageName": "Moq",
                 "versioning": "nuget",
                 "warnings": [],
                 "sourceUrl": "https://github.com/moq/moq",
                 "registryUrl": "https://api.nuget.org/v3/index.json",
                 "currentVersion": "4.18.4",
                 "currentVersionTimestamp": "2022-12-30T11:22:01.400Z",
                 "isSingleVersion": false
               }
             ],
             "packageFile": "fail/fail.csproj"
           },
           {
             "deps": [
               {
                 "datasource": "nuget",
                 "depType": "nuget",
                 "depName": "Moq",
                 "currentValue": "4.18.4",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "4.20.72",
                     "newValue": "4.20.72",
                     "releaseTimestamp": "2024-09-07T01:37:52.233Z",
                     "newMajor": 4,
                     "newMinor": 20,
                     "newPatch": 72,
                     "updateType": "minor",
                     "branchName": "renovate/moq-4.x"
                   }
                 ],
                 "packageName": "Moq",
                 "versioning": "nuget",
                 "warnings": [],
                 "sourceUrl": "https://github.com/moq/moq",
                 "registryUrl": "https://api.nuget.org/v3/index.json",
                 "currentVersion": "4.18.4",
                 "currentVersionTimestamp": "2022-12-30T11:22:01.400Z",
                 "isSingleVersion": false
               }
             ],
             "packageFile": "pass/pass.csproj"
           }
         ]
       }

despite the fact that it should be ignored based on renovate.json

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["config:recommended"],
  "ignorePaths": ["fail/**"]
}

Full logs below.

Logs (if relevant)

Logs

DEBUG: Using RE2 regex engine
DEBUG: Parsing configs
DEBUG: Checking for config file in config.js
DEBUG: No config file found on disk - skipping
DEBUG: File config
       "config": {}
DEBUG: CLI config
       "config": {"repositoryCache": "reset", "platform": "local"}
DEBUG: Env config
       "config": {"hostRules": []}
DEBUG: Combined config
       "config": {"hostRules": [], "repositoryCache": "reset", "platform": "local"}
DEBUG: Enabling forkProcessing while in non-autodiscover mode
DEBUG: Enabling onboardingNoDeps while in non-autodiscover mode
DEBUG: Found valid git version: 2.47.0
DEBUG: Setting global hostRules
DEBUG: Using baseDir: /tmp/renovate
DEBUG: Using cacheDir: /tmp/renovate/cache
DEBUG: Using containerbaseDir: /tmp/renovate/cache/containerbase
DEBUG: Initializing Renovate internal cache into /tmp/renovate/cache/renovate/renovate-cache-v1
DEBUG: Commits limit = null
DEBUG: Setting global hostRules
DEBUG: validatePresets()
DEBUG: Reinitializing hostRules for repo
DEBUG: Clearing hostRules
 INFO: Repository started (repository=local)
       "renovateVersion": "38.105.2"
DEBUG: Using localDir: /home/konrad/Code/github.com/konradmalik/renovate-nuget-ignore-paths (repository=local)
DEBUG: PackageFiles.clear() - Package files deleted (repository=local)
DEBUG: Resetting npmrc (repository=local)
DEBUG: Resetting npmrc (repository=local)
DEBUG: checkOnboarding() (repository=local)
DEBUG: isOnboarded() (repository=local)
DEBUG: findFile(renovate.json) (repository=local)
DEBUG: Got file list using git (repository=local)
DEBUG: Config file exists, fileName: renovate.json (repository=local)
DEBUG: Repo is onboarded (repository=local)
DEBUG: Got file list using git (repository=local)
DEBUG: Found renovate.json config file (repository=local)
DEBUG: Repository config (repository=local)
       "fileName": "renovate.json",
       "config": {
         "$schema": "https://docs.renovatebot.com/renovate-schema.json",
         "extends": ["config:recommended"],
         "ignorePaths": ["fail/**"]
       }
DEBUG: migrateAndValidate() (repository=local)
DEBUG: No config migration necessary (repository=local)
DEBUG: Found repo ignorePaths (repository=local)
       "ignorePaths": ["fail/**"]
DEBUG: No vulnerability alerts found (repository=local)
DEBUG: No baseBranches (repository=local)
DEBUG: extract() (repository=local)
DEBUG: Got file list using git (repository=local)
DEBUG: Using file match: (^|/)tasks/[^/]+\.ya?ml$ for manager ansible (repository=local)
DEBUG: Using file match: (^|/)(galaxy|requirements)(\.ansible)?\.ya?ml$ for manager ansible-galaxy (repository=local)
DEBUG: Using file match: (^|/)\.tool-versions$ for manager asdf (repository=local)
DEBUG: Using file match: azure.*pipelines?.*\.ya?ml$ for manager azure-pipelines (repository=local)
DEBUG: Using file match: (^|/)batect(-bundle)?\.ya?ml$ for manager batect (repository=local)
DEBUG: Using file match: (^|/)batect$ for manager batect-wrapper (repository=local)
DEBUG: Using file match: (^|/)WORKSPACE(|\.bazel|\.bzlmod)$ for manager bazel (repository=local)
DEBUG: Using file match: \.bzl$ for manager bazel (repository=local)
DEBUG: Using file match: (^|/)MODULE\.bazel$ for manager bazel-module (repository=local)
DEBUG: Using file match: (^|/)\.bazelversion$ for manager bazelisk (repository=local)
DEBUG: Using file match: \.bicep$ for manager bicep (repository=local)
DEBUG: Using file match: (^|/)\.?bitbucket-pipelines\.ya?ml$ for manager bitbucket-pipelines (repository=local)
DEBUG: Using file match: (^|/)bitrise\.ya?ml$ for manager bitrise (repository=local)
DEBUG: Using file match: buildkite\.ya?ml for manager buildkite (repository=local)
DEBUG: Using file match: \.buildkite/.+\.ya?ml$ for manager buildkite (repository=local)
DEBUG: Using file match: (^|/)bun\.lockb$ for manager bun (repository=local)
DEBUG: Using file match: (^|/)\.bun-version$ for manager bun-version (repository=local)
DEBUG: Using file match: (^|/)Gemfile$ for manager bundler (repository=local)
DEBUG: Using file match: \.cake$ for manager cake (repository=local)
DEBUG: Using file match: (^|/)Cargo\.toml$ for manager cargo (repository=local)
DEBUG: Using file match: (^|/)\.circleci/.+\.ya?ml$ for manager circleci (repository=local)
DEBUG: Using file match: (^|/)cloudbuild\.ya?ml for manager cloudbuild (repository=local)
DEBUG: Using file match: (^|/)Podfile$ for manager cocoapods (repository=local)
DEBUG: Using file match: (^|/)([\w-]*)composer\.json$ for manager composer (repository=local)
DEBUG: Using file match: (^|/)conanfile\.(txt|py)$ for manager conan (repository=local)
DEBUG: Using file match: (^|/)\.copier-answers(\..+)?\.ya?ml for manager copier (repository=local)
DEBUG: Using file match: (^|/)cpanfile$ for manager cpanfile (repository=local)
DEBUG: Using file match: (^|/)(?:deps|bb)\.edn$ for manager deps-edn (repository=local)
DEBUG: Using file match: ^.devcontainer/devcontainer.json$ for manager devcontainer (repository=local)
DEBUG: Using file match: ^.devcontainer.json$ for manager devcontainer (repository=local)
DEBUG: Using file match: (^|/)(?:docker-)?compose[^/]*\.ya?ml$ for manager docker-compose (repository=local)
DEBUG: Using file match: (^|/|\.)([Dd]ocker|[Cc]ontainer)file$ for manager dockerfile (repository=local)
DEBUG: Using file match: (^|/)([Dd]ocker|[Cc]ontainer)file[^/]*$ for manager dockerfile (repository=local)
DEBUG: Using file match: (^|/)\.drone\.yml$ for manager droneci (repository=local)
DEBUG: Using file match: (^|/)fleet\.ya?ml for manager fleet (repository=local)
DEBUG: Using file match: (?:^|/)gotk-components\.ya?ml$ for manager flux (repository=local)
DEBUG: Using file match: (^|/)\.fvm/fvm_config\.json$ for manager fvm (repository=local)
DEBUG: Using file match: (^|/)\.fvmrc$ for manager fvm (repository=local)
DEBUG: Using file match: (^|/)\.gitmodules$ for manager git-submodules (repository=local)
DEBUG: Using file match: (^|/)(workflow-templates|\.(?:github|gitea|forgejo)/(?:workflows|actions))/.+\.ya?ml$ for manager github-actions (repository=local)
DEBUG: Using file match: (^|/)action\.ya?ml$ for manager github-actions (repository=local)
DEBUG: Using file match: \.gitlab-ci\.ya?ml$ for manager gitlabci (repository=local)
DEBUG: Using file match: \.gitlab-ci\.ya?ml$ for manager gitlabci-include (repository=local)
DEBUG: Using file match: (^|/)gleam.toml$ for manager gleam (repository=local)
DEBUG: Using file match: (^|/)go\.mod$ for manager gomod (repository=local)
DEBUG: Using file match: \.gradle(\.kts)?$ for manager gradle (repository=local)
DEBUG: Using file match: (^|/)gradle\.properties$ for manager gradle (repository=local)
DEBUG: Using file match: (^|/)gradle/.+\.toml$ for manager gradle (repository=local)
DEBUG: Using file match: (^|/)buildSrc/.+\.kt$ for manager gradle (repository=local)
DEBUG: Using file match: \.versions\.toml$ for manager gradle (repository=local)
DEBUG: Using file match: (^|/)versions.props$ for manager gradle (repository=local)
DEBUG: Using file match: (^|/)versions.lock$ for manager gradle (repository=local)
DEBUG: Using file match: (^|/)gradle/wrapper/gradle-wrapper\.properties$ for manager gradle-wrapper (repository=local)
DEBUG: Using file match: (^|/)requirements\.ya?ml$ for manager helm-requirements (repository=local)
DEBUG: Using file match: (^|/)values\.ya?ml$ for manager helm-values (repository=local)
DEBUG: Using file match: (^|/)helmfile\.ya?ml(?:\.gotmpl)?$ for manager helmfile (repository=local)
DEBUG: Using file match: (^|/)Chart\.ya?ml$ for manager helmv3 (repository=local)
DEBUG: Using file match: (^|/)bin/hermit$ for manager hermit (repository=local)
DEBUG: Using file match: ^Formula/[^/]+[.]rb$ for manager homebrew (repository=local)
DEBUG: Using file match: \.html?$ for manager html (repository=local)
DEBUG: Using file match: (^|/)plugins\.(txt|ya?ml)$ for manager jenkins (repository=local)
DEBUG: Using file match: (^|/)jsonnetfile\.json$ for manager jsonnet-bundler (repository=local)
DEBUG: Using file match: ^.+\.main\.kts$ for manager kotlin-script (repository=local)
DEBUG: Using file match: (^|/)kustomization\.ya?ml$ for manager kustomize (repository=local)
DEBUG: Using file match: (^|/)project\.clj$ for manager leiningen (repository=local)
DEBUG: Using file match: (^|/|\.)pom\.xml$ for manager maven (repository=local)
DEBUG: Using file match: ^(((\.mvn)|(\.m2))/)?settings\.xml$ for manager maven (repository=local)
DEBUG: Using file match: (^|/)\.mvn/extensions\.xml$ for manager maven (repository=local)
DEBUG: Using file match: (^|\/).mvn/wrapper/maven-wrapper.properties$ for manager maven-wrapper (repository=local)
DEBUG: Using file match: (^|/)package\.js$ for manager meteor (repository=local)
DEBUG: Using file match: (^|/)Mintfile$ for manager mint (repository=local)
DEBUG: Using file match: (^|/)\.?mise\.toml$ for manager mise (repository=local)
DEBUG: Using file match: (^|/)\.?mise/config\.toml$ for manager mise (repository=local)
DEBUG: Using file match: (^|/)mix\.exs$ for manager mix (repository=local)
DEBUG: Using file match: (^|/)flake\.nix$ for manager nix (repository=local)
DEBUG: Using file match: (^|/)\.node-version$ for manager nodenv (repository=local)
DEBUG: Using file match: (^|/)package\.json$ for manager npm (repository=local)
DEBUG: Using file match: \.(?:cs|fs|vb)proj$ for manager nuget (repository=local)
DEBUG: Using file match: \.(?:props|targets)$ for manager nuget (repository=local)
DEBUG: Using file match: (^|/)dotnet-tools\.json$ for manager nuget (repository=local)
DEBUG: Using file match: (^|/)global\.json$ for manager nuget (repository=local)
DEBUG: Using file match: (^|/)\.nvmrc$ for manager nvm (repository=local)
DEBUG: Using file match: (^|/)src/main/features/.+\.json$ for manager osgi (repository=local)
DEBUG: Using file match: (^|/)pyproject\.toml$ for manager pep621 (repository=local)
DEBUG: Using file match: (^|/)[\w-]*requirements([-.]\w+)?\.(txt|pip)$ for manager pip_requirements (repository=local)
DEBUG: Using file match: (^|/)setup\.py$ for manager pip_setup (repository=local)
DEBUG: Using file match: (^|/)Pipfile$ for manager pipenv (repository=local)
DEBUG: Using file match: (^|/)pyproject\.toml$ for manager poetry (repository=local)
DEBUG: Using file match: (^|/)\.pre-commit-config\.ya?ml$ for manager pre-commit (repository=local)
DEBUG: Using file match: (^|/)pubspec\.ya?ml$ for manager pub (repository=local)
DEBUG: Using file match: (^|/)Puppetfile$ for manager puppet (repository=local)
DEBUG: Using file match: (^|/)\.python-version$ for manager pyenv (repository=local)
DEBUG: Using file match: (^|/)\.ruby-version$ for manager ruby-version (repository=local)
DEBUG: Using file match: (^|/)runtime.txt$ for manager runtime-version (repository=local)
DEBUG: Using file match: \.sbt$ for manager sbt (repository=local)
DEBUG: Using file match: project/[^/]*\.scala$ for manager sbt (repository=local)
DEBUG: Using file match: project/build\.properties$ for manager sbt (repository=local)
DEBUG: Using file match: (^|/)repositories$ for manager sbt (repository=local)
DEBUG: Using file match: (^|/)\.scalafmt.conf$ for manager scalafmt (repository=local)
DEBUG: Using file match: (^|/)setup\.cfg$ for manager setup-cfg (repository=local)
DEBUG: Using file match: (^|/)Package\.swift for manager swift (repository=local)
DEBUG: Using file match: \.tf$ for manager terraform (repository=local)
DEBUG: Using file match: (^|/)\.terraform-version$ for manager terraform-version (repository=local)
DEBUG: Using file match: (^|/)terragrunt\.hcl$ for manager terragrunt (repository=local)
DEBUG: Using file match: (^|/)\.terragrunt-version$ for manager terragrunt-version (repository=local)
DEBUG: Using file match: \.tflint\.hcl$ for manager tflint-plugin (repository=local)
DEBUG: Using file match: ^\.travis\.ya?ml$ for manager travis (repository=local)
DEBUG: Using file match: (^|/)\.vela\.ya?ml$ for manager velaci (repository=local)
DEBUG: Using file match: (^|/)vendir\.yml$ for manager vendir (repository=local)
DEBUG: Using file match: ^\.woodpecker(?:/[^/]+)?\.ya?ml$ for manager woodpecker (repository=local)
DEBUG: Matched 2 file(s) for manager nuget: fail/fail.csproj, pass/pass.csproj (repository=local)
DEBUG: manager extract durations (ms) (repository=local)
       "managers": {"nuget": 15}
DEBUG: Found nuget package files (repository=local)
DEBUG: Found 2 package file(s) (repository=local)
 INFO: Dependency extraction complete (repository=local)
       "stats": {
         "managers": {"nuget": {"fileCount": 2, "depCount": 2}},
         "total": {"fileCount": 2, "depCount": 2}
       }
DEBUG: hostRules: no authentication for api.nuget.org (repository=local)
DEBUG: Using queue: host=api.nuget.org, concurrency=16 (repository=local)
DEBUG: PackageFiles.add() - Package file saved for base branch (repository=local)
DEBUG: Package releases lookups complete (repository=local)
DEBUG: branchifyUpgrades (repository=local)
DEBUG: detectSemanticCommits() (repository=local)
DEBUG: getCommitMessages (repository=local)
DEBUG: semanticCommits: detected "unknown" (repository=local)
DEBUG: semanticCommits: disabled (repository=local)
DEBUG: 2 flattened updates found: Moq, Moq (repository=local)
DEBUG: Returning 1 branch(es) (repository=local)
DEBUG: config.repoIsOnboarded=true (repository=local)
DEBUG: packageFiles with updates (repository=local)
       "config": {
         "nuget": [
           {
             "deps": [
               {
                 "datasource": "nuget",
                 "depType": "nuget",
                 "depName": "Moq",
                 "currentValue": "4.18.4",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "4.20.72",
                     "newValue": "4.20.72",
                     "releaseTimestamp": "2024-09-07T01:37:52.233Z",
                     "newMajor": 4,
                     "newMinor": 20,
                     "newPatch": 72,
                     "updateType": "minor",
                     "branchName": "renovate/moq-4.x"
                   }
                 ],
                 "packageName": "Moq",
                 "versioning": "nuget",
                 "warnings": [],
                 "sourceUrl": "https://github.com/moq/moq",
                 "registryUrl": "https://api.nuget.org/v3/index.json",
                 "currentVersion": "4.18.4",
                 "currentVersionTimestamp": "2022-12-30T11:22:01.400Z",
                 "isSingleVersion": false
               }
             ],
             "packageFile": "fail/fail.csproj"
           },
           {
             "deps": [
               {
                 "datasource": "nuget",
                 "depType": "nuget",
                 "depName": "Moq",
                 "currentValue": "4.18.4",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "4.20.72",
                     "newValue": "4.20.72",
                     "releaseTimestamp": "2024-09-07T01:37:52.233Z",
                     "newMajor": 4,
                     "newMinor": 20,
                     "newPatch": 72,
                     "updateType": "minor",
                     "branchName": "renovate/moq-4.x"
                   }
                 ],
                 "packageName": "Moq",
                 "versioning": "nuget",
                 "warnings": [],
                 "sourceUrl": "https://github.com/moq/moq",
                 "registryUrl": "https://api.nuget.org/v3/index.json",
                 "currentVersion": "4.18.4",
                 "currentVersionTimestamp": "2022-12-30T11:22:01.400Z",
                 "isSingleVersion": false
               }
             ],
             "packageFile": "pass/pass.csproj"
           }
         ]
       }
DEBUG: detectSemanticCommits() (repository=local)
DEBUG: semanticCommits: returning "disabled" from cache (repository=local)
DEBUG: Repository timing splits (milliseconds) (repository=local)
       "splits": {"init": 1323, "extract": 343, "lookup": 822},
       "total": 2489
DEBUG: Package cache statistics (repository=local)
       "get": {"count": 2, "avgMs": 7, "medianMs": 12, "maxMs": 12, "totalMs": 14},
       "set": {"count": 0, "avgMs": 0, "medianMs": 0, "maxMs": 0, "totalMs": 0}
DEBUG: HTTP statistics (repository=local)
       "hosts": {
         "api.nuget.org": {
           "count": 2,
           "reqAvgMs": 231,
           "reqMedianMs": 430,
           "reqMaxMs": 430,
           "queueAvgMs": 1,
           "queueMedianMs": 2,
           "queueMaxMs": 2
         }
       },
       "requests": 2
DEBUG: HTTP cache statistics (repository=local)
DEBUG: Lookup statistics (repository=local)
       "nuget": {"count": 2, "avgMs": 713, "medianMs": 718, "maxMs": 718, "totalMs": 1425}
 INFO: Repository finished (repository=local)
       "cloned": undefined,
       "durationMs": 2489
DEBUG: Checking file package cache for expired items
DEBUG: Deleted 1 of 26 file cached entries in 26ms

[rarkins]

If you're using config:recommended then you need to put your ignorePaths inside nuget {}. You can see the presets you need to override here: https://docs.renovatebot.com/presets-default/#ignoremodulesandtests

[konradmalik]

hmm, this works but is very confusing I have to say. Is there anything obvious why can't nuget work "normally" under the common ignorePaths?
Edit: ok, I think this is because config:recommended provides a separate, different from global, ignorePaths and regardless of what I put in ignorePaths the "nuget" one will be used for nuget unless I override it as you suggested. I think I get it.

Regardless, information about this should def. be here: https://docs.renovatebot.com/nuget/ I think.

[rarkins]

It would be great if you can add it to https://github.com/renovatebot/renovate/blob/main/docs/usage/nuget.md

[konradmalik]

PR here: #33020