Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace enums with union/object #18903

Merged
merged 8 commits into from
Nov 14, 2022
Merged

refactor: replace enums with union/object #18903

merged 8 commits into from
Nov 14, 2022

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Nov 14, 2022 •
edited
Loading

Changes

  • Convert the following enums to union:
  1. PrState
  2. Limit
  3. AzurePrVote
  4. QualifierRank
  5. QualifierTypes

Context

@RahulGautamSingh RahulGautamSingh mentioned this pull request Nov 14, 2022
Merged
@RahulGautamSingh RahulGautamSingh changed the title refactor: convert PrState and Limit to union type refactor: replace enums with union/object Nov 14, 2022
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 14, 2022 14:07
@rarkins rarkins enabled auto-merge (squash) November 14, 2022 16:24
@rarkins rarkins merged commit af3b203 into renovatebot:main Nov 14, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulGautamSingh @renovate-release @JamieMagee @rarkins