fix(git): Don't quote unicode paths #18963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
requested review from
rarkins and
viceice
and removed request for
rarkins
zharinov
commented
Nov 17, 2022
|
Any potential problems? Eg package files with spaces on their name stop working or something like that |
|
Don't think so. Everything that follows SHA is treated as file name by the regex, including spaces |
rarkins
previously approved these changes
Nov 17, 2022
JamieMagee
previously approved these changes
Nov 17, 2022
viceice
previously approved these changes
Nov 17, 2022
auto-merge was automatically disabled
November 17, 2022 19:15
Head branch was pushed to by a user without write access
zharinov
dismissed stale reviews from viceice, JamieMagee, and rarkins
via
66f2dcf
viceice
approved these changes
Nov 18, 2022
|
🎉 This PR is included in version 34.27.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See core.quotePath Git option.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: