Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change onboardingNoDeps to enum, and behavior similar to forkProcessing #28101

Closed
rarkins opened this issue Mar 24, 2024 · 6 comments · Fixed by #28133
Closed

Change onboardingNoDeps to enum, and behavior similar to forkProcessing #28101

rarkins opened this issue Mar 24, 2024 · 6 comments · Fixed by #28133
Assignees
@RahulGautamSingh
Labels
breaking Breaking change, requires major version bump core:onboarding Related to the onboarding process priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) v38

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 24, 2024

Describe the proposed change(s).

Change onboardingNoDeps from boolean to enum, defaulting to "auto" like forkProcessing. It should also be set to "enabled" if autodiscover is false.
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:onboarding Related to the onboarding process labels Mar 24, 2024
@RahulGautamSingh
Copy link
Collaborator

What is the reasoning behind auto and not disabled since the default behaviour will be same in both cases?

@RahulGautamSingh RahulGautamSingh mentioned this issue Mar 26, 2024
Merged
6 tasks
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 26, 2024

Unless I'm misunderstanding your question: defaulting to disabled means that it should not change to enabled unless the user configures it. But instead, we want it to automatically configure itself to enabled if running in non-autodiscover mode

@RahulGautamSingh
Copy link
Collaborator

When autodiscover: false && onboardingNoDeps: 'disabled'. Do we switch onboardingNoDeps to enabled?

@rarkins
Copy link
Collaborator Author

rarkins commented Mar 26, 2024

No, keep it disabled

@HonkingGoose
Copy link
Collaborator

@rarkins commented on the related PR:

Sorry, changed my mind! Let's just release this with v38 and with no migration - just a breaking change notification. Otherwise we also need to massage env and CLI params too. Please remove the migrations!

So I'll label this breaking change and v38. 😉

@HonkingGoose HonkingGoose added breaking Breaking change, requires major version bump v38 labels Mar 27, 2024
@rarkins rarkins added the status:in-progress Someone is working on implementation label Apr 14, 2024
rarkins pushed a commit that referenced this issue Apr 14, 2024
@RahulGautamSingh
feat(config): change onboardingNoDeps from boolean to enum (#28133)
7fa65fd 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 20, 2024
@RahulGautamSingh @rarkins
feat(config): change onboardingNoDeps from boolean to enum (#28133)
d927b87 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 20, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
858b3ea 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 21, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
3a03e41 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 21, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
bc55594 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 22, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
331a072 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 26, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
1181466 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Apr 29, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
adb8fae 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 3, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
d759cdf 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 4, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
8063a25 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 5, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
f0d02a8 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 6, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
802d389 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 11, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
4755d7c 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 19, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
9049fb2 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
RahulGautamSingh added a commit to RahulGautamSingh/renovate that referenced this issue May 20, 2024
@RahulGautamSingh
feat(config)!: change onboardingNoDeps from boolean to enum (reno…
ba871f3 
…vatebot#28133)

Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes renovatebot#28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue May 31, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
b2b2d42 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Jun 9, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
40b0414 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Jul 23, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
9b2035f 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Jul 23, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
c12f4ed 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
viceice pushed a commit that referenced this issue Jul 23, 2024
@RahulGautamSingh @viceice
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
2642b47 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
viceice pushed a commit that referenced this issue Jul 24, 2024
@RahulGautamSingh @viceice
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
72a8f33 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this issue Jul 25, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
4a06093 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RahulGautamSingh RahulGautamSingh

Labels
breaking Breaking change, requires major version bump core:onboarding Related to the onboarding process priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality) v38
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): change onboardingNoDeps from boolean to enum RahulGautamSingh/renovate
4 participants
@rarkins @HonkingGoose @renovate-release @RahulGautamSingh