Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globalExtends should not override global config #28131

Closed
rarkins opened this issue Mar 26, 2024 · 8 comments · Fixed by #28145
Closed

globalExtends should not override global config #28131

rarkins opened this issue Mar 26, 2024 · 8 comments · Fixed by #28145
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features status:pending-release Pending next major release type:bug Bug fix of existing functionality v38

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 26, 2024 •
edited
Loading

Describe the proposed change(s).

globalExtends config should be merged "before" explicit config, not after. i.e. explicit config is more important than presets, like we do in repo config
@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features core:config Related to config capabilities and presets labels Mar 26, 2024
@rarkins rarkins self-assigned this Mar 26, 2024
@rarkins rarkins added the status:in-progress Someone is working on implementation label Mar 26, 2024
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 26, 2024

@viceice @secustor although I'm convinced this current behavior is wrong, do you think it's best we merge this as a "breaking" fix in v38?

@viceice
Copy link
Member

viceice commented Mar 26, 2024

🤔 probably yes 🤷‍♂️

@rarkins rarkins added breaking Breaking change, requires major version bump v38 labels Mar 26, 2024
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 26, 2024

Can we v38 this week?

@secustor
Copy link
Collaborator

There's quite a list of stuff still to do for v38. Do you want to get this on the App?
If not, then we could feature flag this new behaviour and make it the default in v38.

@rarkins
Copy link
Collaborator Author

rarkins commented Mar 26, 2024

Correct behavior can now be opted into via #28144

@rarkins rarkins mentioned this issue Mar 26, 2024
Merged
6 tasks
rarkins added a commit that referenced this issue Mar 27, 2024
@rarkins
fix(config): globalExtends merge default (#28145)
d9ba74d 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
@fdw
Copy link

fdw commented Mar 27, 2024

Thank you so much!

@fdw
Copy link

fdw commented Mar 28, 2024

I can confirm that it works 🙂

rarkins added a commit that referenced this issue Apr 11, 2024
@rarkins
fix(config): globalExtends merge default (#28145)
5bca657 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins added a commit that referenced this issue Apr 13, 2024
@rarkins
fix(config): globalExtends merge default (#28145)
fb013c9 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins added a commit that referenced this issue Apr 14, 2024
@rarkins
fix(config): globalExtends merge default (#28145)
3be5a77 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins added a commit that referenced this issue Apr 14, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
6689768 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Apr 14, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
654bba8 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Apr 14, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
c7271bc 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Apr 14, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
0b9d4e3 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Apr 20, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
750958f 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Apr 20, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
cf0ec57 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Apr 21, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
fdf23fe 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Apr 21, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
451efdb 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Apr 21, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
329d959 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Apr 21, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
83e5964 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Apr 22, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
55d421e 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue May 4, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
521d9db 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue May 5, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
62a6614 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue May 5, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
d5865e4 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue May 6, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
65a7227 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue May 6, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
1891c08 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue May 11, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
88e5e97 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue May 11, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
8c31ac3 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue May 19, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
9ec61cf 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue May 19, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
43a437d 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue May 31, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
e649217 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue May 31, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
545fe54 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Jun 9, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
868f946 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Jun 9, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
e1233d3 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
@rarkins rarkins added status:pending-release Pending next major release and removed status:in-progress Someone is working on implementation labels Jul 1, 2024
rarkins added a commit that referenced this issue Jul 23, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
e68821a 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Jul 23, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
50be059 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Jul 23, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
3e8a4c8 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Jul 23, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
717d4e5 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
viceice pushed a commit that referenced this issue Jul 23, 2024
@rarkins @viceice
fix(config)!: globalExtends merge order (#28145)
36bdaf5 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
viceice pushed a commit that referenced this issue Jul 23, 2024
@secustor @viceice
feat(manager/pep621)!: remove group name from depName (#28193)
d7e2dff 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
viceice pushed a commit that referenced this issue Jul 24, 2024
@rarkins @viceice
fix(config)!: globalExtends merge order (#28145)
d479bb1 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
viceice pushed a commit that referenced this issue Jul 24, 2024
@secustor @viceice
feat(manager/pep621)!: remove group name from depName (#28193)
e55903d 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins added a commit that referenced this issue Jul 25, 2024
@rarkins
fix(config)!: globalExtends merge order (#28145)
3febb38 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes #28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
rarkins pushed a commit that referenced this issue Jul 25, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
c59927b 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
rarkins pushed a commit that referenced this issue Jul 25, 2024
@secustor @rarkins
feat(manager/pep621)!: remove group name from depName (#28193)
2ad12cc 
Previously, the “depName” for pep621 was constructed using groupName/packageName, which in turn meant that the same dependency was upgraded in different branches if it was present in multiple groups. Instead, depName is now set to packageName. This will lead to a change of branch name for pep621 updates.

Closes #28131

BREAKING CHANGE: depName for pep621 dependencies changes, which will lead to branch name changes, which will lead to some autoclosing and reopening of PRs.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features status:pending-release Pending next major release type:bug Bug fix of existing functionality v38
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: globalExtends merge default renovatebot/renovate
5 participants
@viceice @fdw @rarkins @secustor @renovate-release