Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: shareable configs only work with JSON format #10100

Merged

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented May 21, 2021

Changes:

  • Document that shareable configs only work with the JSON format

Context:

Based on end-user confusion about shareable configs not working with the JSON5 format (see discussion #10087).

For now we only support the normal JSON format until we implement feature request in issue #7674.

I did a search for share in the *.md files, and added the information that JSON is the only supported format if you want to use the shareable config.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose requested review from rarkins and viceice May 21, 2021 10:00
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can allow json5 in a future pr, as it won't open security concerns, it just allows some easier syntax. Eg inline comments.

@HonkingGoose HonkingGoose marked this pull request as ready for review May 21, 2021 12:41
@bmuenzenmeyer
Copy link

I'd be interested in giving a go at json5 support if you accept outside contributions.

@viceice
Copy link
Member

viceice commented May 21, 2021

I'd be interested in giving a go at json5 support if you accept outside contributions.

Sure, shouldn't be hard, as we already have and use json5 dependency.

@JamieMagee JamieMagee enabled auto-merge (squash) May 21, 2021 15:56
@bmuenzenmeyer
Copy link

Sure, shouldn't be hard, as we already have and use json5 dependency.

@viceice can you give me the shortest of clues as to what file(s) to start looking at? I am happy to put in the work, but an initial set of breadcrumbs is invaluable.

@JamieMagee JamieMagee merged commit 5f32574 into renovatebot:main May 21, 2021
@HonkingGoose HonkingGoose deleted the docs/shareable-configs-json-only branch May 21, 2021 16:16
@viceice
Copy link
Member

viceice commented May 21, 2021

Sure, shouldn't be hard, as we already have and use json5 dependency.

@viceice can you give me the shortest of clues as to what file(s) to start looking at? I am happy to put in the work, but an initial set of breadcrumbs is invaluable.

You need to check files lib/config/presets/... and the json methods in lib/platform/..., which are used to fetch local or hosted presets.

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants