-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: shareable configs only work with JSON format #10100
docs: shareable configs only work with JSON format #10100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can allow json5 in a future pr, as it won't open security concerns, it just allows some easier syntax. Eg inline comments.
I'd be interested in giving a go at json5 support if you accept outside contributions. |
Sure, shouldn't be hard, as we already have and use |
@viceice can you give me the shortest of clues as to what file(s) to start looking at? I am happy to put in the work, but an initial set of breadcrumbs is invaluable. |
You need to check files |
🎉 This PR is included in version 25.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Context:
Based on end-user confusion about shareable configs not working with the JSON5 format (see discussion #10087).
For now we only support the normal JSON format until we implement feature request in issue #7674.
I did a search for
share
in the*.md
files, and added the information that JSON is the only supported format if you want to use the shareable config.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: