-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github-releases): getDigest() #10947
Conversation
At a high level, this seems safe as it won't do anything unless there's a currentValue and currentDigest. |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add "**/test/**",
to tsconfig.app.json
exclude.
🎉 This PR is included in version 25.69.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Adds an implementation of
getDigest()
for thegithub-releases
datasource.Like #10931 , this implementation relies on passing the current version and digest to the query site:
DigestAsset
:<5KB
assets attached to the release are download and parsed as checksum files (e.g.SHASUMS.txt
,${asset}.shasum
). This uses string matching, so any digest algorithm is supported.sha256
andsha512
digests encoded in hexadecimal.DigestAsset
is mapped on to the corresponding next releases, with a mapper for filenames that include the version.Context:
I want to be able to pin digests of assets attached to GitHub releases, I've assembled a few projects of interest in (and tested this branch against) https://github.com/thepwagner/renovate-github-releases-digests .
.sha256sum
files for each assetsha256.txt
assertThe method for mapping assets to digests is ported from updatedHash in a GitHub Action I use for maintaining dependencies; I'm hoping to archive that repo and use Renovate.
Supersedes #10931
Closes #7928
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: