-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manager/composer): respect the PHP override in composer.json #13657
Merged
viceice
merged 8 commits into
renovatebot:main
from
internalsystemerror:feature/composer-config-platform
Jan 20, 2022
Merged
fix(manager/composer): respect the PHP override in composer.json #13657
viceice
merged 8 commits into
renovatebot:main
from
internalsystemerror:feature/composer-config-platform
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Lockett <gary@creativecow.uk>
viceice
reviewed
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Signed-off-by: Gary Lockett <gary@creativecow.uk>
rarkins
requested changes
Jan 20, 2022
viceice
reviewed
Jan 20, 2022
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
I will be able to fix this and finish this off tonight |
Signed-off-by: Gary Lockett <gary@creativecow.uk>
…omposer-config-platform
Never mind, that was a quick fix. Sorry I'd missed this on the initial upload so I was able to push it now. |
rarkins
approved these changes
Jan 20, 2022
viceice
approved these changes
Jan 20, 2022
viceice
changed the title
fix(composer): respect the PHP override in composer.json
fix(manager/composer): respect the PHP override in composer.json
Jan 20, 2022
🎉 This PR is included in version 31.38.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This ensures that renovate respects the PHP override set in
composer.json
: https://getcomposer.org/doc/06-config.md#platform.Given the following:
Then the detected PHP version used for composer should be
7.4.27
. This PR adds that awareness to renovate.Context:
There are several issues related which should be closed by this (for instance #4396). And mainly came about after this discussion #13637.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: