Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hermit binary source #16259

Merged
merged 17 commits into from
Aug 5, 2022
Merged

feat: add hermit binary source #16259

merged 17 commits into from
Aug 5, 2022

Conversation

lyonlai
Copy link
Contributor

@lyonlai lyonlai commented Jun 27, 2022 •
edited by viceice
Loading

Changes

As part of the Hermit manager feature from #16250, this PR contains the support for hermit as a binary source for renovate.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins reviewed Jun 27, 2022
View reviewed changes
@lyonlai lyonlai requested a review from rarkins June 28, 2022 23:42
PhilipAbed
PhilipAbed requested changes Jun 29, 2022
View reviewed changes
JamieMagee
JamieMagee reviewed Jul 1, 2022
View reviewed changes
JamieMagee
JamieMagee reviewed Jul 1, 2022
View reviewed changes
JamieMagee
JamieMagee reviewed Jul 1, 2022
View reviewed changes
@lyonlai
fix: hermit binary source better implementation
13f0ab8 
1. simplifies findHermitCwd loop
2. use internal fs packages rather than fs-extra direct
3. various of small simplifications
@lyonlai lyonlai requested review from JamieMagee and PhilipAbed July 1, 2022 05:51
@lyonlai
Copy link
Contributor Author

lyonlai commented Jul 27, 2022

@rarkins As the hermit manager PR is getting closer to merge. I would like to get this PR going as well. Would you mind taking a look again?

rarkins
rarkins requested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in mobile this week so limited in what I can review and test

viceice
viceice requested changes Jul 27, 2022
View reviewed changes
@lyonlai lyonlai requested a review from viceice July 27, 2022 10:07
@rarkins
Copy link
Collaborator

rarkins commented Jul 29, 2022

I'm ok with this feature as long as its presence doesn't change anything for non hermit users. BTW will this mean that the hermit manager is only applicable for self-hosted though, considering that binarySource is a self hosted option?

@lyonlai
Copy link
Contributor Author

lyonlai commented Jul 29, 2022

When saying hermit manager did you mean hermit binary source? Hermit manager for me is the one living in the lib/modules/manager folder.

If hermit binary source is what you meant then you are correct that

  • this implementation will not change anything for non-hermit user.
  • Hermit as binary source is only applicable for self-hosted. Not for other run options where user has no control on the binarySource attribute.

@rarkins
Copy link
Collaborator

rarkins commented Jul 29, 2022

So the manager can be used independently of the binarySource?

@lyonlai
Copy link
Contributor Author

lyonlai commented Jul 30, 2022

Yes, the hermit manager is independent of the hermit binarySource. I run hermit manager with docker binarySource before I implement this feature.

viceice
viceice reviewed Jul 30, 2022
View reviewed changes
@lyonlai lyonlai requested a review from viceice August 1, 2022 02:13
viceice
viceice reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add show the test repo? i like to have a look how it works.

@viceice
Copy link
Member

viceice commented Aug 1, 2022

See also reopened discussion

@lyonlai lyonlai requested a review from viceice August 1, 2022 06:38
@lyonlai
Copy link
Contributor Author

lyonlai commented Aug 1, 2022

can you please add show the test repo? i like to have a look how it works.

Here is a minimal hermit repository setup with a go(v1.17) project. Should be enough to test out the hermit as binary source. Let me know if you need anything else. @viceice

https://github.com/lyonlai/hermit-binary-source-example

viceice
viceice reviewed Aug 1, 2022
View reviewed changes
@viceice viceice requested a review from rarkins August 1, 2022 11:11
@lyonlai
Copy link
Contributor Author

lyonlai commented Aug 4, 2022

Hey @rarkins, have you got a chance to take a look at this yet?

@rarkins rarkins enabled auto-merge (squash) August 5, 2022 05:06
@rarkins rarkins merged commit f07dcfb into renovatebot:main Aug 5, 2022
@lyonlai lyonlai mentioned this pull request Aug 5, 2022
Merged
6 tasks
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.146.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lyonlai lyonlai mentioned this pull request Aug 8, 2022
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

@PhilipAbed PhilipAbed Awaiting requested review from PhilipAbed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lyonlai @rarkins @viceice @renovate-release @JamieMagee @PhilipAbed