Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fs): Remove unused proxied functions #16311

Merged
merged 6 commits into from
Jun 29, 2022
Merged

refactor(fs): Remove unused proxied functions #16311

merged 6 commits into from
Jun 29, 2022

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice June 28, 2022 15:49
viceice
viceice reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't the plan to change all FS io to our utils?

viceice
viceice previously approved these changes Jun 28, 2022
View reviewed changes
lib/util/fs/proxies.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice June 29, 2022 04:39
viceice
viceice reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing

lib/util/fs/index.spec.ts Outdated Show resolved Hide resolved
@zharinov @viceice
Update lib/util/fs/index.spec.ts
167dccd 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zharinov zharinov requested a review from viceice June 29, 2022 05:17
@viceice viceice enabled auto-merge (squash) June 29, 2022 05:34
@viceice viceice merged commit 0687799 into renovatebot:main Jun 29, 2022
@viceice viceice deleted the refactor/remove-unused-fs-proxies branch June 29, 2022 07:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zharinov @viceice