Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fs): Scope checks for filesystem functions #16511

Merged
merged 16 commits into from
Jul 14, 2022
Merged

feat(fs): Scope checks for filesystem functions #16511

merged 16 commits into from
Jul 14, 2022

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 10, 2022 •
edited
Loading

Changes

  • Provide ensureLocalPath and ensureCachePath helpers that throw on traversal errors
  • Introduce new error type: FILE_ACCESS_VIOLATION_ERROR
  • Refactor tests

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov mentioned this pull request Jul 10, 2022
Closed
6 tasks
@zharinov zharinov requested review from viceice and rarkins July 10, 2022 20:06
@zharinov zharinov marked this pull request as ready for review July 10, 2022 20:06
viceice
viceice reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing coverage

rarkins
rarkins reviewed Jul 11, 2022
View reviewed changes
lib/util/fs/util.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested review from viceice and rarkins July 12, 2022 08:07
viceice
viceice reviewed Jul 12, 2022
View reviewed changes
lib/util/fs/index.spec.ts Outdated Show resolved Hide resolved
lib/util/fs/index.spec.ts Outdated Show resolved Hide resolved
lib/util/fs/index.ts Outdated Show resolved Hide resolved
lib/util/fs/util.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice July 12, 2022 08:59
@rarkins rarkins enabled auto-merge (squash) July 14, 2022 05:56
@rarkins rarkins merged commit d0fe5f9 into renovatebot:main Jul 14, 2022
@zharinov zharinov deleted the feat/fs-scope-checks branch July 14, 2022 08:21
zharinov added a commit to zharinov/renovate that referenced this pull request Jul 14, 2022
@zharinov
Revert "feat(fs): Scope checks for filesystem functions (renovatebot#…
13c527c 
…16511)"

This reverts commit d0fe5f9.
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.115.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vitoyucepi vitoyucepi mentioned this pull request Jul 15, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @renovate-release @viceice @rarkins