fix: join env var lines with os.EOL to fix test failure on different systems #16993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viceice this fixes the failure in main on |
|
still need help to tag |
rarkins
previously approved these changes
Aug 5, 2022
lyonlai
force-pushed
the
ylai/fix-get-hermit-env-test-error-on-windows
branch
from
24696ff to
0b7b29a
Compare
viceice
approved these changes
Aug 5, 2022
|
🎉 This PR is included in version 32.146.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Hermit env variable join should be using os.EOL to be able to pass in different systems
Context
continue of #16985
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: