-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replacement): datasource changes #17881
Merged
viceice
merged 8 commits into
renovatebot:main
from
t-kulmburg:feat/replacement-part-datasource
Sep 27, 2022
Merged
feat(replacement): datasource changes #17881
viceice
merged 8 commits into
renovatebot:main
from
t-kulmburg:feat/replacement-part-datasource
Sep 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
viceice
reviewed
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test to validate? otherwise LGTM
I added a test that shows getDigestConfig using replacementName as packageName if provided |
viceice
reviewed
Sep 24, 2022
…' into feat/replacement-part-datasource
viceice
approved these changes
Sep 27, 2022
viceice
changed the title
feat: replacement split: datasource changes
feat(replacement): datasource changes
Sep 27, 2022
🎉 This PR is included in version 32.208.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested I am splitting my replacement pr #17476.
This pr adds "replacementName" to the "getDigestInputConfig" and adds usage in getDigest if provided.
This will enable replacements for dependencies with digest, as now the digest for the new replacing dependency will be used.