Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replacement): datasource changes #17881

Merged
merged 8 commits into from
Sep 27, 2022

Conversation

t-kulmburg
Copy link
Contributor

As requested I am splitting my replacement pr #17476.
This pr adds "replacementName" to the "getDigestInputConfig" and adds usage in getDigest if provided.
This will enable replacements for dependencies with digest, as now the digest for the new replacing dependency will be used.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test to validate? otherwise LGTM

@t-kulmburg
Copy link
Contributor Author

I added a test that shows getDigestConfig using replacementName as packageName if provided

@t-kulmburg t-kulmburg requested a review from viceice September 21, 2022 09:01
@t-kulmburg t-kulmburg requested a review from viceice September 27, 2022 11:30
@viceice viceice changed the title feat: replacement split: datasource changes feat(replacement): datasource changes Sep 27, 2022
@viceice viceice enabled auto-merge (squash) September 27, 2022 13:08
@viceice viceice merged commit e14f09d into renovatebot:main Sep 27, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.208.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants