Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): lock file maintenance #18082

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 3, 2022

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge (squash) October 3, 2022 01:30
renovate-approve[bot]
renovate-approve bot previously approved these changes Oct 3, 2022
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Oct 3, 2022
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Oct 3, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Oct 3, 2022
JamieMagee
JamieMagee previously approved these changes Oct 3, 2022
@viceice
Copy link
Member

viceice commented Oct 3, 2022

snapshot errors

@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2022

Test Suites: 19 failed, 518 passed, 537 total
Tests:       104 failed, 10227 passed, 10331 total

This is unexpected

@viceice
Copy link
Member

viceice commented Oct 3, 2022

Test Suites: 19 failed, 518 passed, 537 total
Tests:       104 failed, 10227 passed, 10331 total

This is unexpected

all snapshot failures

@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2022

I guess they're inline snapshots though, because jest -u does not fix them.

@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2022

Example:

  ● modules/manager/npm/update/locked-dependency/package-lock/get-locked › getLockedDependencies() › finds bundled dependency

    expect(received).toMatchSnapshot(properties)

    Matcher error: Expected properties must be an object

    Expected properties has type:  array
    Expected properties has value: [{"bundled": true, "dev": true, "integrity": "sha1-7QMXwyIGT3lGbAKWa922Bas32Zg=", "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-3.0.0.tgz", "version": "3.0.0"}]

      50 |       expect(
      51 |         getLockedDependencies(bundledPackageLockJson, 'ansi-regex', '3.0.0')
    > 52 |       ).toMatchSnapshot([
         |         ^
      53 |         {
      54 |           bundled: true,
      55 |           dev: true,

      at Object.toMatchSnapshot (node_modules/jest-snapshot/build/index.js:246:13)
      at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:346:30)
      at Object.throwingMatcher (node_modules/expect/build/index.js:347:15)
      at Object.<anonymous> (lib/modules/manager/npm/update/locked-dependency/package-lock/get-locked.spec.ts:52:9)

@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2022

Perhaps it's a bug?

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 4 times, most recently from f122731 to 053be98 Compare October 6, 2022 05:18
@JamieMagee
Copy link
Contributor

Looks like the jest bug was already opened upstream: jestjs/jest#13352

I think there might also be a typescript-eslint issue, or something common between them!

@rarkins
Copy link
Collaborator

rarkins commented Oct 6, 2022

It sounds to me that test/lint libraries which may "break" things semi-intentionally in new releases should be pinning dependencies all the way down if possible. This is very bad that a lock file maintenance PR causes tests to fail.

Can we pin with resolutions for now if it's not too complex?

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 5 times, most recently from fd18d2d to e47a470 Compare October 6, 2022 15:34
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 18 times, most recently from b05f968 to 357958d Compare October 10, 2022 15:22
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 357958d to 400d61e Compare October 11, 2022 00:59
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% if we want toMatchObject or toMatchInlineSnapshot

@renovate renovate bot merged commit 7935a7b into main Oct 11, 2022
@renovate renovate bot deleted the renovate/lock-file-maintenance branch October 11, 2022 04:47
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.232.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants