Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/gradle): prefix version catalog aliases with "libs." #18830

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Nov 8, 2022

Changes

Prefix version catalog aliases with libs, as the version catalog default name, to prevent confusion with variables that have the same name and to comply with gradle behavior:

For example the aliases groovyCore, groovyJson and groovyXml would be mapped to the libs.groovyCore, libs.groovyJson and libs.groovyXml accessors respectively.

This also fixes a related issue: renovate stores library aliases as variable for later use. Since gradle configs reference them with the catalog name prefixed only, these references never worked until now, since the prefix wasn't prepended.

Context

Closes #18825

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: renovate-demo/18825#1

@viceice viceice requested a review from zharinov November 8, 2022 20:29
@rarkins rarkins enabled auto-merge (squash) November 9, 2022 00:33
@rarkins rarkins merged commit fb56b1f into renovatebot:main Nov 9, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.21.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle manager fails when using same version and library names
4 participants