fix: use correct values for replacements

[t-kulmburg]

Changes

Changes the replacement updates to use replacementName and replacementVersion from config instead of dependency

Context

This was part of my other PR.

Reason for this change is that I encountered a problem when replacing 2 different versions of the same dependency with different new dependencies.

I also tested this in my big replacement demo repository to ensure it doesn't break other replacements when combined with my other PR, which contains the main replacement feature.

• closes Replacements cause ignoring prerelease/compatibility #14962

Example

Dockerfile:

FROM openjdk:8-jre
FROM openjdk:17-slim-buster

packageRules:

    {
    "matchManagers": ["dockerfile"],
    "matchPackageNames": ["openjdk"],
    "matchCurrentVersion": "/^17/",
    "replacementName": "eclipse-temurin",
    "replacementVersion": "17-jdk-jammy"
    },
    {
      "matchManagers": ["dockerfile"],
      "matchPackageNames": ["openjdk"],
      "matchCurrentVersion": "/^8/",
      "replacementName": "eclipse-temurin",
      "replacementVersion": "8u342-b07.1-jre"
    },

Log output:

logger.debug(`CONFIG: ${config.replacementName} -- ${config.replacementVersion}`)
logger.debug(`DEP: ${dependency.replacementName} -- ${depName.replacementVersion}`)

DEBUG: CONFIG: eclipse-temurin -- 8u342-b07.1-jre (repository=xx/renovate-test)
DEBUG: DEP: eclipse-temurin -- 8u342-b07.1-jre (repository=xx/renovate-test)

DEBUG: CONFIG: eclipse-temurin -- 17-jdk-jammy (repository=xx/renovate-test)
DEBUG: DEP: eclipse-temurin -- 8u342-b07.1-jre (repository=xx/renovate-test)

This shows that when using dependency, both will get replaced with the same version.
When using config however, we get the replacement we wanted.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[astellingwerf]

How can it be that this fix does not impact any test?

[astellingwerf]

I think you're possibly fixing #14962 with this, but we're still hiding the fact that replacements are implement in the wrong/a illogical place.

[viceice]

Looks good, we should try to add tests to not break in future

[renovate-release]

🎉 This PR is included in version 34.22.1 🎉

The release is available on:

• GitHub release
• 34.22.1

Your semantic-release bot 📦🚀

[viceice]

@JordiVM That is unrelated to this PR. Please open a new Discussion for futher help.