-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(volta): make sure volta uses the same yarn package overwrite #18893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the format changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we already set his anywhere else.
this also doesn't work for simple ranges like ^3.2.0
Yes, it's the same piece of code as used in the check for engines: Ranges are not supported in Volta, so that shouldn't be an issue. |
ok, but it will fill soon again as yarn V4 is around the corner. so i think you should check if it's not starting with |
I've improved the check for both cases |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 34.26.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
This makes sure that the 'volta' behavior for Yarn is the same as the 'engines' behavior.
Context
When using yarn 2+ in Volta, Renovate will make rollback PR's because it can't find new versions. This is caused because it's looking in the wrong repository.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: