refactor(jest): enable resetMocks

[JamieMagee]

Changes

• Sets resetMocks¹ in jest.config.ts (equivalent to calling jest.resetAllMocks² before each test)
• Removes any explicit calls to jest.resetAllMocks
• Fixes tests that were relying on mocks from other tests

This automatically clears mock implementations or return values before every test. This makes it more difficult to write tests which rely on each other.

Tests still to fix:

• ...

Context

Second part of #18768
Follow-up from #18779

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

Footnotes

1. https://jestjs.io/docs/configuration#resetmocks-boolean ↩

2. https://jestjs.io/docs/jest-object#jestresetallmocks ↩

[viceice]

1. This allows users to be more lazy when writing tests. 😕
2. We do some static mocking (module scope), which is now broken

[rarkins]

What's the path forward for this?

[HonkingGoose]

@JamieMagee might be good to pull in the latest changes from main, because @zharinov changed a lot of test-related stuff.