Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pep621): implement manager #22082

Merged
merged 11 commits into from
May 15, 2023

Conversation

secustor
Copy link
Collaborator

Changes

Implements a pep621 manager to support the preferred format for Python projects.

The manager currently manages:

  • dependencies
  • dev dependencies
  • PDM tooling dependencies )
  • additional PyPi registries via pdm.sources

Context

Closes #10187

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/secustor/pdm-pep621-reproduction/issues/2

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any considerations for related lock files we should think about now?

@secustor
Copy link
Collaborator Author

I have a second PR in the works with lockfile support for PDM.

Support for this would be part of the processor interface.

I have decided to split this up to ease the review and because we have to coordinate with containerbase.

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@secustor secustor requested a review from viceice May 12, 2023 20:40
@secustor secustor added this pull request to the merge queue May 15, 2023
Merged via the queue into renovatebot:main with commit 019c75c May 15, 2023
@secustor secustor deleted the feat/implement_pep621 branch May 15, 2023 08:12
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.83.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New python manager for PEP621
5 participants