-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(datasource): Add additional examples for custom datasource #23558
Conversation
Added the examples for hashicorp and offline dependencies
Needs linting errors to be fixed, else LGTM. |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use JSON, that way we get code highlighting in the documentation.
The original codefences in that document were actually partly json5 (which is among the supported languages of github), hence I thought that this is the solution. Will change back and update the code to json compliance. |
The linting fails because of the first JSON block |
Sorry - i had the codeblock in my editor replaced but apparently not commited. Now finally done. Sorry again! |
Hope now we got it finally, the output of the task from |
You can run |
So instead of a quick contribution this turned into a crazy undertaking. Btw the linter wanted to have this: # renovate: datasource=custom.nexus_generic depName=something versioning=loose
something_version: '77' instead of # renovate: datasource=custom.nexus_generic depName=something versioning=loose
something_version: "77" which led to a change of the overall regex etc. Very opionated style... anyway now it should be complete finally. |
Thanks so much for your help and patience @secustor ! |
You're welcome. Thanks for your contribution! |
🎉 This PR is included in version 36.27.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Added the examples for hashicorp and offline dependencies for the custom datasource
Context
Following the request of a maintainer here.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: