Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gomod): Notify extra packages updated by "go get" #28938

Merged
merged 63 commits into from
May 27, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 8, 2024

Changes

Context

Closes #27775
Closes #25047

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

zharinov and others added 30 commits May 8, 2024 14:53
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…29050)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…enovatebot#29045)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…29051)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zharinov zharinov requested a review from viceice May 16, 2024 15:12
viceice
viceice previously approved these changes May 16, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the message, using this as an example: renovate-reproductions/25047#1 (comment)

I discovered that this PR closes #25047 too

@rarkins rarkins added this pull request to the merge queue May 27, 2024
Merged via the queue into renovatebot:main with commit cc5f68e May 27, 2024
37 checks passed
@rarkins rarkins deleted the feat/gomod-notify-extra-packages branch May 27, 2024 12:57
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.378.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator

Looks like we accidentally broke the Markdown rendering on Bitbucket platforms with this PR (#28938). See Discussion:

And here's the PR that tries to fix the reported problem:

@HonkingGoose HonkingGoose added the regression Issue about a regression bug, or the PR caused it label Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Issue about a regression bug, or the PR caused it
Projects
None yet