Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yarn): search parent directories for yarn configuration #29415

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jaylindquist
Copy link
Contributor

Changes

Yarn searches for configuration files in parent directories

  • .yarnrc: "Yarn will merge .yarnrc files up the file tree."
  • .yarnrc.yml: "While Yarn will automatically find them in the parent directories, they should usually be kept at the root of your project (often your repository)"

This can affect the URL when searching for dependencies in custom registries when the package.json file is in a subdirectory while the yarn configuration is in a parent directory.

This change will search for yarn configuration files in parent directories when extracting dependencies for the npm manager.

Context

We have some teams that have a repository similar to the following structure

.
├── .yarnrc
├── package.json
└── projectA/
    └── package.json

The .yarnrc file includes an internal registry while projectA/package.json includes the internal dependency. Currently, renovate can't find the internal dependency because it will search the default registry as the configuration file is in the parent directory.

Yarn will search parent directories for configurations, so when running yarn install it will install the dependency correctly. This change updates the search for yarn configuration files to include parent directories

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Jun 3, 2024
Merged via the queue into renovatebot:main with commit 40dbc86 Jun 3, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.387.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants