Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(versioning): Add a NodeJS Lambda Versioning module #32480

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Garethp
Copy link

@Garethp Garethp commented Nov 12, 2024

Changes

This PR adds a versioning module for NodeJS Lambda Runtimes provided by AWS

Context

As discussed in this discussion, I want to keep versions of Node in with the release schedule of AWS Lambdas. AWS NodeJS Lambdas release within a month or two after a NodeJS version goes LTS so there is a period of time where a version of Node is LTS but not available as a Lambda Runtime. To keep a project's node dependency on the same version as the Runtime it will run on, I need to be able to set those dependencies (nvmrc, docker etc...) to follow the Lambda Runtime release schedule rather than the NodeJS release schedule.

Since this is meant to be a drop-in replacement for any packages that follow node versioning, I've re-used most of the functions provided by the node versioning module and only changed the isStable function.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice November 21, 2024 11:20
@viceice viceice changed the title feat(nodejs-lambda-versioning): Add a NodeJS Lambda Versioning module feat(versioning): Add a NodeJS Lambda Versioning module Nov 21, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice viceice marked this pull request as draft December 12, 2024 21:17
@rarkins rarkins added the auto:inactive-pr PR has become inactive and we want to prompt the submitter label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Hi there,

This PR appears to have been inactive for a while. Please let us know if you are still working on it, or if we can close it for now.

Thanks, the Renovate team

…g some new test fixtures to hit otherwise unreliable code
@Garethp
Copy link
Author

Garethp commented Feb 17, 2025

@viceice, I've removed the unused code and changed how I'm mocking the data. I've also mocked out dataFiles so that I can test some of the if conditions that are based on unstable data from the datasource. Let me know if this is the appropriate way of testing that instability.

@Garethp Garethp marked this pull request as ready for review February 21, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:inactive-pr PR has become inactive and we want to prompt the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants