Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): replace INFO with DEBUG logs #33478

Merged
merged 5 commits into from
Jan 16, 2025
Merged

feat(logger): replace INFO with DEBUG logs #33478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f65dcb8
refactor(logger): remove templating from INFO log messages
RahulGautamSingh Jan 8, 2025
0f98668
Apply Suggestions
RahulGautamSingh Jan 9, 2025
80cda20
fix test
RahulGautamSingh Jan 11, 2025
89e5898
remove DRY-RUN changes
RahulGautamSingh Jan 12, 2025
d092eaa
fix tests
RahulGautamSingh Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/modules/datasource/galaxy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,8 @@ export class GalaxyDatasource extends Datasource {
}
}
if (body.results.length === 0) {
logger.info(
{ dependency: packageName },
`Received no results from ${galaxyAPIUrl}`,
logger.debug(
`Received no results for ${packageName} from ${galaxyAPIUrl} `,
);
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/modules/manager/git-submodules/artifacts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function updateArtifacts({
const res: UpdateArtifactsResult[] = [];
updatedDeps.forEach((dep) => {
// TODO: types (#22198)
logger.info(`Updating submodule ${dep.depName}`);
logger.debug(`Updating submodule ${dep.depName}`);
res.push({
file: { type: 'addition', path: dep.depName!, contents: '' },
});
Expand Down
2 changes: 1 addition & 1 deletion lib/modules/manager/npm/update/locked-dependency/package-lock/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export async function updateLockedDependency(
currentVersion,
);
if (lockedDeps.some((dep) => dep.bundled)) {
logger.info(
logger.debug(
`Package ${depName}@${currentVersion} is bundled and cannot be updated`,
);
return { status: 'update-failed' };
Expand Down
3 changes: 1 addition & 2 deletions lib/modules/versioning/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ export const Versioning = z

let versioning = versionings.get(versioningName);
if (!versioning) {
logger.info(
{ versioning: versioningSpec },
logger.debug(
`Versioning: '${versioningSpec}' not found, falling back to ${defaultVersioning.id}`,
);
return defaultVersioning.api;
Expand Down
4 changes: 2 additions & 2 deletions lib/workers/repository/process/vulnerabilities.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ describe('workers/repository/process/vulnerabilities', () => {
config,
packageFiles,
);
expect(logger.logger.info).toHaveBeenCalledWith(
expect(logger.logger.debug).toHaveBeenCalledWith(
'No fixed version available for vulnerability GHSA-xxxx-yyyy-zzzz in fake 4.17.11',
);
});
Expand Down Expand Up @@ -449,7 +449,7 @@ describe('workers/repository/process/vulnerabilities', () => {
config,
packageFiles,
);
expect(logger.logger.info).toHaveBeenCalledWith(
expect(logger.logger.debug).toHaveBeenCalledWith(
'No fixed version available for vulnerability GHSA-xxxx-yyyy-zzzz in fake 1.5.1',
);
});
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/process/vulnerabilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ export class Vulnerabilities {
packageFileConfig,
} = vul;
if (is.nullOrUndefined(fixedVersion)) {
logger.info(
logger.debug(
`No fixed version available for vulnerability ${vulnerability.id} in ${packageName} ${depVersion}`,
);
return null;
Expand Down
Loading