Skip to content

feat(bazel): Support local file based bcr #35273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rayahhhmed
Copy link
Contributor

@Rayahhhmed Rayahhhmed commented Apr 8, 2025

Changes

Added a check in Bazel index.ts to check if it is a file based URL, if so read the file path, else it makes a http request using the BCR url.

Context

In addition to the previous PR. This PR adds the ability to allow Renovate to read an in-house file based Bazel repository.
This is linked in this #35252 issue.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Rayahhhmed Rayahhhmed mentioned this pull request Apr 8, 2025
6 tasks
@Rayahhhmed Rayahhhmed changed the title Feature/rayahhhhmed supporting local machine bcr Supporting local file based bcr Apr 8, 2025
@rarkins rarkins changed the title Supporting local file based bcr feat(bazel): Support local file based bcr Apr 9, 2025
@Rayahhhmed
Copy link
Contributor Author

@rarkins added a new test for this, any how i can speed up this PR?

rarkins
rarkins previously approved these changes Apr 19, 2025
@rarkins rarkins requested review from viceice and secustor April 19, 2025 12:49
@Rayahhhmed
Copy link
Contributor Author

@viceice tysm for the quick 👀. I have fixed the changes you have proposed, please lemme know if I could do anything more 👍🏾

@Rayahhhmed Rayahhhmed requested review from viceice and rarkins April 19, 2025 23:05
@rarkins rarkins enabled auto-merge April 20, 2025 06:11
@rarkins rarkins added this pull request to the merge queue Apr 20, 2025
Merged via the queue into renovatebot:main with commit 345cb95 Apr 20, 2025
40 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.252.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants