-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(bazel): Support local file based bcr #35273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rarkins
merged 16 commits into
renovatebot:main
from
Rayahhhmed:feature/rayahhhhmed-supporting-local-machine-bcr
Apr 20, 2025
Merged
feat(bazel): Support local file based bcr #35273
rarkins
merged 16 commits into
renovatebot:main
from
Rayahhhmed:feature/rayahhhhmed-supporting-local-machine-bcr
Apr 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…thub.com:Rayahhhmed/renovate into feature/rayahhhhmed-supporting-local-machine-bcr
@rarkins added a new test for this, any how i can speed up this PR? |
rarkins
previously approved these changes
Apr 19, 2025
viceice
reviewed
Apr 19, 2025
viceice
reviewed
Apr 19, 2025
@viceice tysm for the quick 👀. I have fixed the changes you have proposed, please lemme know if I could do anything more 👍🏾 |
…thub.com:Rayahhhmed/renovate into feature/rayahhhhmed-supporting-local-machine-bcr
secustor
approved these changes
Apr 20, 2025
🎉 This PR is included in version 39.252.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a check in Bazel
index.ts
to check if it is a file based URL, if so read the file path, else it makes a http request using the BCR url.Context
In addition to the previous PR. This PR adds the ability to allow Renovate to read an in-house file based Bazel repository.
This is linked in this #35252 issue.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: