Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace linkify-markdown #9954

Merged
merged 13 commits into from
May 19, 2021
Merged

refactor: replace linkify-markdown #9954

merged 13 commits into from
May 19, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented May 11, 2021

Changes:

Removes linkify-markdown to fix GHSA-w5p7-h5w8-2hfq. Also allows us to use newer remark and remark-github.

Not sure why there are snapshot changes. 😕

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from JamieMagee and rarkins May 11, 2021 12:32
@viceice
Copy link
Member Author

viceice commented May 12, 2021

remark-github github has now build-in types 🎉

remarkjs/remark-github#29

@viceice
Copy link
Member Author

viceice commented May 17, 2021

Ready for another review. package patching no longer nessesary. 🎉

@rarkins
Copy link
Collaborator

rarkins commented May 17, 2021

Can we run it on our example repos to see if/how it changes markdown compared to the existing solution?

@viceice
Copy link
Member Author

viceice commented May 17, 2021

Can we run it on our example repos to see if/how it changes markdown compared to the existing solution?

this pr: https://github.com/viceice-tests/renovate-changelog1

current main: https://github.com/viceice-tests/renovate-changelog2

They look same to me. Any other dependency to add and check?

@rarkins rarkins enabled auto-merge (squash) May 17, 2021 13:34
@rarkins rarkins merged commit d8f4b86 into main May 19, 2021
@rarkins rarkins deleted the feat/replace-linkify-md branch May 19, 2021 03:24
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.21.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants