-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate git version #9979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also log as warning at runtime? So if a user is using a custom docker image or the plain npm package?
lib/util/git/index.ts
Outdated
const globalGit = Git(); | ||
try { | ||
const raw = await globalGit.raw(['--version']); | ||
console.warn(raw); // eslint-disable-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Leftover from testing?
🎉 This PR is included in version 25.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Updates development docs and adds a test
Context:
Helpful for #9938
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: