Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are overridden if multiple selects are displayed on the same page #203

Closed
bmaximilian opened this issue Sep 23, 2020 · 1 comment
Closed

Comments

@bmaximilian
Copy link
Contributor

Bug: Icons are overridden if multiple selects are displayed on the same page

Current State

  • A component renders a form with multiple SectionedMultiSelect
  • Some selects receive the prop iconRenderer some don't (even more problematic if there are different iconRenderers)
  • The iconRenderer of the component that is constructed last is applied to all SectionedMultiSelect that are rendered

Desired State

  • A component renders a form with multiple SectionedMultiSelect
  • The iconRenderer of the select is only applied to the component that receives it as prop

Info

In line 22, icon is defined globally. The constructor of the select assigns the iconRenderer or the MaterialIcons to the Icon variable.
This icon variable is assigned multiple times if multiple selects are rendered.

bmaximilian added a commit to bmaximilian/react-native-sectioned-multi-select that referenced this issue Sep 23, 2020
bmaximilian added a commit to bmaximilian/react-native-sectioned-multi-select that referenced this issue Sep 23, 2020
renrizzolo added a commit that referenced this issue Sep 25, 2020
@renrizzolo
Copy link
Owner

fixed in 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants