Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving assertion failure when parsing fetch request #114

Closed
wants to merge 2 commits into from

Conversation

brightredchilli
Copy link

Hi rentzsch, im referencing:#81

I ran into this problem with one of my fetch requests, and I propose the fix above. What was happening is that the _resolveKeyPathType: fails when the key path contains an attribute. I hope this is helpful. Let me know if I can clarify anything.

@rentzsch
Copy link
Owner

rentzsch commented Jun 5, 2012

Looking good, thanks. One request, though: could you add an example fetch request to the mogeneratorTestMule that needs this fix? That will help me understand its use-case and ensure it doesn't get broken in the future.

@brightredchilli
Copy link
Author

I would be happy to except im quite confused by the mogeneratortestmule. At
no point does it actually seem to include the files generated by
mogenerator, and at no point does it seem to run mogenerator itself. Im not
even sure where the test cases are run-is it just in the app delegate?
There seems to be only one test case now.

On Tue, Jun 5, 2012 at 11:21 AM, Jonathan 'Wolf' Rentzsch <
reply@reply.github.com

wrote:

Looking good, thanks. One request, though: could you add an example fetch
request to the mogeneratorTestMule that needs this fix? That will help me
understand its use-case and ensure it doesn't get broken in the future.


Reply to this email directly or view it on GitHub:
#114 (comment)

@rentzsch
Copy link
Owner

rentzsch commented Jun 6, 2012

Ah, mogeneratorTestMule uses the old include.m mechanism -- see its mogenerate.command file for the invocation and notice the project includes the generated include.m file.

Yeah, the "test case" is just to get the app compiled has have it successfully run.

Thanks!

@brightredchilli
Copy link
Author

thanks, ill take a look into it.

On Tue, Jun 5, 2012 at 11:56 PM, Jonathan 'Wolf' Rentzsch <
reply@reply.github.com

wrote:

Ah, mogeneratorTestMule uses the old include.m mechanism -- see its
mogenerate.command file for the invocation and notice the project
includes the generated include.m file.

Yeah, the "test case" is just to get the app compiled has have it
successfully run.

Thanks!


Reply to this email directly or view it on GitHub:
#114 (comment)

@rentzsch
Copy link
Owner

Dup of #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants