Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in model compiler instead of relying on Xcode #225

Merged
merged 4 commits into from
Apr 26, 2015

Conversation

atomicbird
Copy link
Collaborator

This updates mogenerator to use an internal model compilation scheme based on momcom whenever the model uses the Xcode 4+ file format. Model files are compiled directly in mogenerator instead of calling out to Xcode's compiler. This removes the dependency on Xcode's shifting location of the momc tool for those files.

Tests in mogenerator/tests pass.

@rentzsch
Copy link
Owner

Nice! I'm about to ship 1.28, so I'll assign this to 1.29.

@rentzsch rentzsch added this to the 1.29 milestone Jul 22, 2014
@justin
Copy link
Collaborator

justin commented Apr 26, 2015

Is this still relevant @atomicbird? What do we need to do to get it merged in for 1.29?

@atomicbird
Copy link
Collaborator Author

Still relevant, the goal is to have mogenerator handle compiling the model itself instead of figuring out how to call Xcode in a fragile if/then/else. I can try to update this to target the swift12 branch if it's convenient, but it's not really a Swift related change.

justin pushed a commit that referenced this pull request Apr 26, 2015
Use built-in model compiler instead of relying on Xcode
@justin justin merged commit 73fccca into rentzsch:master Apr 26, 2015
@justin
Copy link
Collaborator

justin commented Apr 26, 2015

Thanks, @atomicbird!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants