Add constant structs for the property names #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sampling Mike Ash's post about namespaced constants (http://www.mikeash.com/pyblog/friday-qa-2011-08-19-namespaced-constants-and-functions.html), this adds the generation of constant structs to access the attribute, relationship and fetched property names. This makes sure that when you're creating a fetch request, you can use these values to guarantee their existence.
|
Sounds like an awesome addition, looking forward to using it. Should it be optionally enabled perhaps, instead of always on? Should be simple with template vars. |
|
I did wonder whether it should be optional, though I can't see too much harm in generating them and not using them, especially if it removes a preference. (Though I know the command line types love options!) |
rentzsch
added a commit
that referenced
this pull request
Aug 30, 2011
[NEW] [Mike-Ash-style](http://www.mikeash.com/pyblog/friday-qa-2011-08-19-namespaced-constants-and-functions.html) namespaced constants for entity attribute names and relationships. Allows you to write things like `[mo valueForKey:PersonMOAttributes.hairColor]` instead of `[mo valueForKey:@"hairColor"]`. The main benefit here is the compile-time errors when the `hairColor` attribute is removed or renamed. (Daniel Tull)
|
I'm going to have it always-on. I don't see a big win being able to turn it off. |
jonmarimba
pushed a commit
to jonmarimba/mogenerator
that referenced
this pull request
Nov 1, 2011
--- Sampling Mike Ashs post about namespaced constants (http://www.mikeash.com/pyblog/friday-qa-2011-08-19-namespaced-constants-and-functions.html), this adds the generation of constant structs to access the attribute, relationship and fetched property names. This makes sure that when youre creating a fetch request, you can use these values to guarantee their existence.
|
These added structs are incompatible with ARC. I get compiler errors "error: ARC forbids Objective-C objects in structs or unions" |
|
Are you using the ARC flag ( |
|
@jdmuys, @danielctull thanks for clearing this up, it will go in v1.24's changelog |
ddrccw
pushed a commit
to ddrccw/mogenerator
that referenced
this pull request
Jan 20, 2014
--- Sampling Mike Ashs post about namespaced constants (http://www.mikeash.com/pyblog/friday-qa-2011-08-19-namespaced-constants-and-functions.html), this adds the generation of constant structs to access the attribute, relationship and fetched property names. This makes sure that when youre creating a fetch request, you can use these values to guarantee their existence.
ddrccw
pushed a commit
to ddrccw/mogenerator
that referenced
this pull request
Jan 20, 2014
[NEW] [Mike-Ash-style](http://www.mikeash.com/pyblog/friday-qa-2011-08-19-namespaced-constants-and-functions.html) namespaced constants for entity attribute names and relationships. Allows you to write things like `[mo valueForKey:PersonMOAttributes.hairColor]` instead of `[mo valueForKey:@"hairColor"]`. The main benefit here is the compile-time errors when the `hairColor` attribute is removed or renamed. (Daniel Tull)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sampling Mike Ash's post about namespaced constants (http://www.mikeash.com/pyblog/friday-qa-2011-08-19-namespaced-constants-and-functions.html), this adds the generation of constant structs to access the attribute, relationship and fetched property names. This makes sure that when you're creating a fetch request, you can use these values to guarantee their existence.