feat:delete ollama models #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhavyajain21
requested review from
samlhuillier and
joseplayero
and removed request for
samlhuillier
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements the ability to delete Ollama models, addressing issue #452 by adding new IPC handlers and UI components for model deletion.
- Added new IPC handlers in
electron/main/llm/ipcHandlers.tsfor fetching available models and deleting LLMs - Exposed new functions
deleteLLMandgetAvailableModelsto the renderer process inelectron/preload/index.ts - Updated
DefaultLLMSelectorcomponent insrc/components/Settings/LLMSettings/DefaultLLMSelector.tsxto include a delete option for Ollama models - Modified
useLLMConfigshook insrc/components/Settings/LLMSettings/hooks/use-llm-configs.tsto allow direct updates to LLM configurations - Consider improving error handling and user feedback for model deletion operations
4 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
joseplayero
requested changes
Oct 17, 2024
|
@joseplayero , I've worked on the addressed review comments. Please take a look! |
joseplayero
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #452
/claim #452