Remove flashcards #470
Merged
Remove flashcards #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Major refactoring to remove the flashcard feature from Reor, including UI components, utilities, types, and all related functionality.
- Removed entire
/src/components/Flashcarddirectory containing core flashcard functionality (FlashcardCreateModal, FlashcardReviewModal, FlashcardsCore) - Cleaned up flashcard references in IconsSidebar and keyboard shortcuts (mod+L)
- Removed flashcard-related state management from ModalContext
- Simplified directory creation logic in
src/components/File/NewDirectory.tsxto only use vault directory - Updated welcome note and README to remove flashcard feature mentions
16 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| https://github.com/reorproject/reor/assets/17236551/94a1dfeb-3361-45cd-8ebc-5cfed81ed9cb | ||
| <https://github.com/reorproject/reor/assets/17236551/94a1dfeb-3361-45cd-8ebc-5cfed81ed9cb> |
There was a problem hiding this comment.
style: URL should be wrapped in markdown link syntax []() for consistency
Comment on lines
74
to
75
| const finalPath = await window.path.join(directoryPath, directoryRelativePath) | ||
| window.fileSystem.createDirectory(finalPath) |
There was a problem hiding this comment.
logic: No error handling for createDirectory call - could silently fail if directory already exists or permissions issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.