Fix modal #486
Merged
Fix modal #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Version bump and modal component z-index modification to address visibility issues in the application's modal system.
- Removed explicit
z-[9999]class from modal container insrc/components/Common/Modal.tsx, relying instead on natural DOM stacking context - Incremented version from 0.2.29 to 0.2.30 in
package.jsonto reflect modal changes - Potential visibility concern: modal may be obscured by other elements with higher z-index values despite portal rendering
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -36,7 +36,7 @@ const ReorModal: React.FC<ModalProps> = ({ | |||
|
|
|||
| const modalContent = ( | |||
| <div | |||
| className={`fixed inset-0 z-[9999] flex h-screen w-screen items-center justify-center bg-black/40 ${tailwindStylesOnBackground}`} | |||
| className={`fixed inset-0 flex h-screen w-screen items-center justify-center bg-black/40 ${tailwindStylesOnBackground}`} | |||
There was a problem hiding this comment.
logic: removing z-[9999] could cause modal to be hidden behind other elements with higher z-index values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.