add universal link flag #2352
Closed
add universal link flag #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/scaffold/src/partials/w3m-connecting-wc-mobile/index.ts
Outdated
Show resolved
Hide resolved
enesozturk
previously approved these changes
Jun 3, 2024
enesozturk
dismissed
their stale review
There might be changes to complete this feature
| @@ -103,6 +103,7 @@ export interface WcWallet { | |||
| image_url?: string | |||
| order?: number | |||
| mobile_link?: string | null | |||
| link_mode?: string | null | |||
There was a problem hiding this comment.
this might bring confusion as we are developing another feature called link-mode 👀
There was a problem hiding this comment.
tomiir
reviewed
Jun 19, 2024
Comment on lines
+23
to
+25
| useEffect(() => { | ||
| window.Telegram?.WebApp.ready() | ||
| }, []) |
There was a problem hiding this comment.
is this reqquired? what happens if it fails?
There was a problem hiding this comment.
This is used by Telegram to initialize the website inside a Mini App. Outside telegram it doesn't have any effect. We can remove this from labs if needed, it's just here for testing purposes.
tomiir
reviewed
Jun 19, 2024
tomiir
approved these changes
Jul 10, 2024
|
@glitch-txs should we move to draft until the issue with iOS is resolved ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
How to test the preview in Telegram:
Changes
enableUniversalLinksflag to use Universal Linking on mobile, this will improve Telegram Mini Apps supportBlocked by https://github.com/WalletConnect/cloud-app/pull/1195
Associated Issues
closes #...