fix: siwe map to siwx onSignOut callback #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a36a62d The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
zoruka
requested review from
tomiir,
svenvoskamp and
Cali93
and removed request for
tomiir and
svenvoskamp
Cali93
reviewed
Nov 25, 2024
packages/siwe/src/mapToSIWX.ts
Outdated
Comment on lines
58
to
59
| const compareSessionAddress = session?.address.toLowerCase() | ||
| const compareCaipAddress = CoreHelperUtil?.getPlainAddress(activeCaipAddress)?.toLowerCase() |
There was a problem hiding this comment.
nit: variable names seem off
tomiir
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onSignOutnot being called foractiveCaipAddresschanges;signOut/onSignOutnot being called onuseDisconnecthook calls;AppKitSIWEClientsignInandsignOutmethods to call new SIWX handlers;mapToSIWXfunction and usage against AppKit.Type of change
Checklist