feat: siwx cloud auth config flag #3424

zoruka · 2024-12-10T14:50:23Z

Description

Please include a brief summary of the change.

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link

…siwe-to-siwx-migration

…we config

…siwe-to-siwx-migration

…ct/web3modal into feat/siwx-cloud-auth

…iwx-cloud-auth

…list

…hentication loading

…iwx-cloud-auth

changeset-bot · 2024-12-10T14:50:26Z

⚠️ No Changeset found

Latest commit: bd70839

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-10T14:50:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-builder	❌ Failed (Inspect)			Dec 10, 2024 3:30pm
appkit-laboratory	❌ Failed (Inspect)		💬 Add feedback	Dec 10, 2024 3:30pm
appkit-vue-solana	❌ Failed (Inspect)			Dec 10, 2024 3:30pm
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 10, 2024 3:30pm
vue-wagmi-example	❌ Failed (Inspect)			Dec 10, 2024 3:30pm

…iwx-cloud-auth-config

Cali93 · 2024-12-10T15:43:50Z

packages/appkit/src/client.ts

+    OptionsController.subscribeKey('features', async features => {
+      if (features?.auth) {
+        if (OptionsController.state.siwx) {
+          console.warn("SIWX config already enabled, 'auth' feature will not be enabled")


Suggested change

console.warn("SIWX config already enabled, 'auth' feature will not be enabled")

console.warn("SIWX config already provided, the default Reown Auth feature will not be used.")

Cali93 · 2024-12-10T15:44:44Z

apps/laboratory/src/pages/library/wagmi.tsx

@@ -21,7 +21,8 @@ const modal = createAppKit({
  networks: ConstantsUtil.EvmNetworks,
  projectId: ConstantsUtil.ProjectId,
  features: {
-    analytics: true
+    analytics: true,
+    auth: true


Why do we need this flag here if we already have the siwx param?

Suggested change

auth: true

auth: true

Cali93 · 2024-12-10T15:45:50Z

packages/core/src/controllers/ApiController.ts

+      params: ApiController._getSdkProperties()
+    })
+    console.log({ isAnalyticsEnabled, isAppKitAuthEnabled })
+    OptionsController.setFeatures({ analytics: isAnalyticsEnabled, auth: isAppKitAuthEnabled })


Could we set siwx's value to the CloudAuthSIWX instance if it's enabled ?

zoruka and others added 30 commits November 4, 2024 19:26

refactor: add params in getNonce function

4559f59

feat: add map to siwx function

4938fdb

refactor: apply siwx over siwe

2ce57a2

Merge branch 'main' of github.com:WalletConnect/web3modal into chore/…

07a6605

…siwe-to-siwx-migration

Merge branch 'main' of github.com:WalletConnect/web3modal into chore/…

63c34ef

…siwe-to-siwx-migration

fix: issues after rebase

6e4cbed

chore: revert ts issue changes on solana adapter

2e01a07

fix: formating issue

04a1c90

Merge branch 'main' of github.com:WalletConnect/web3modal into chore/…

3190dcf

…siwe-to-siwx-migration

fix: missing siwx initialization

36598e9

refactor: move validation to LocalStorage to keep independent from si…

edb0fe5

…we config

fix: fix LocalStorage validation

b72b68d

Merge branch 'main' of github.com:WalletConnect/web3modal into chore/…

fc061f2

…siwe-to-siwx-migration

fix: missing setClientId

7bec91c

feat: add siwx cloud auth storage

c30c03a

Merge branch 'chore/siwe-to-siwx-migration' of github.com:WalletConne…

2b511f7

…ct/web3modal into feat/siwx-cloud-auth

chore: update branch and adde clientId in the request

bd8aab5

fix: formating issue

bbb3561

Merge branch 'main' of github.com:WalletConnect/web3modal into feat/s…

18760c2

…iwx-cloud-auth

wip: get correct nonce and set token

4c5806e

fix(siwx-msg): chain ID should be after version

ed1f6d9

refactor: create CloudAuthSIWX config instead of extending DefaultSIWX

3a4f132

fix(auth): fix auth flow to set token

260d1da

fix: informal message clear chain id namespace

6fc6e42

fix: setSessions logic to clear session and get correct session from …

3113939

…list

fix: universalProviderAuthenticate to only accept eip155 and show aut…

ebc7a1d

…hentication loading

feat: add autoClose flag for snackbar

4f78505

Merge branch 'main' of github.com:WalletConnect/web3modal into feat/s…

975ff8b

…iwx-cloud-auth

test: add tests for CloudAuthSIWX

e318f4d

fix: dependecy static version and formatting

b752093

zoruka added 9 commits December 5, 2024 14:28

Merge branch 'main' of github.com:WalletConnect/web3modal into feat/s…

75e3934

…iwx-cloud-auth

chore: add page for siwx cloud auth

7fa8841

test: fix SnackController tests and add test for autoClose

aea0bdf

test: fix SnackController tests and add test for autoClose

f6d5742

test: mock host and href

8670737

Merge branch 'main' of github.com:WalletConnect/web3modal into feat/s…

22dd48d

…iwx-cloud-auth

Merge branch 'main' into feat/siwx-cloud-auth

3dae36b

Merge branch 'main' into feat/siwx-cloud-auth

0c0e557

feat: add setup for auth flag and siwx usage

4e2b45a

Base automatically changed from feat/siwx-cloud-auth to main December 10, 2024 14:51

Merge branch 'main' of github.com:WalletConnect/web3modal into feat/s…

bd70839

…iwx-cloud-auth-config

vercel bot had a problem deploying to Preview – appkit-vue-solana December 10, 2024 15:24 Failure

vercel bot had a problem deploying to Preview – appkit-laboratory December 10, 2024 15:26 Failure

vercel bot had a problem deploying to Preview – appkit-builder December 10, 2024 15:27 Failure

vercel bot deployed to Preview – appkit-wagmi-cdn-example December 10, 2024 15:29 View deployment

vercel bot had a problem deploying to Preview – vue-wagmi-example December 10, 2024 15:29 Failure

Cali93 reviewed Dec 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: siwx cloud auth config flag #3424

feat: siwx cloud auth config flag #3424

zoruka commented Dec 10, 2024

changeset-bot bot commented Dec 10, 2024 •

edited

Loading

vercel bot commented Dec 10, 2024 •

edited

Loading

Cali93 Dec 10, 2024

Cali93 Dec 10, 2024

Cali93 Dec 10, 2024

	console.warn("SIWX config already enabled, 'auth' feature will not be enabled")
	console.warn("SIWX config already provided, the default Reown Auth feature will not be used.")

feat: siwx cloud auth config flag #3424

Are you sure you want to change the base?

feat: siwx cloud auth config flag #3424

Conversation

zoruka commented Dec 10, 2024

Description

Type of change

Associated Issues

Showcase (Optional)

Checklist

changeset-bot bot commented Dec 10, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Dec 10, 2024 • edited Loading

Cali93 Dec 10, 2024

Choose a reason for hiding this comment

Cali93 Dec 10, 2024

Choose a reason for hiding this comment

Cali93 Dec 10, 2024

Choose a reason for hiding this comment

changeset-bot bot commented Dec 10, 2024 •

edited

Loading

vercel bot commented Dec 10, 2024 •

edited

Loading