Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: laboratory add siwx status #3451

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Dec 12, 2024

Description

Adds SIWX status in laboratory.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 7:56pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 7:56pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 7:56pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 7:56pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 7:56pm
vue-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 7:56pm

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: f6759cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.68% 18357 / 28381
🔵 Statements 64.68% 18357 / 28381
🔵 Functions 55.18% 1581 / 2865
🔵 Branches 78.49% 3023 / 3851
File CoverageNo changed files found.
Generated in workflow #8718 for commit f6759cd by the Vitest Coverage Report Action


useEffect(() => {
const interval = setInterval(() => {
const newStatus = localStorage.getItem(localStorageKey) || ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not get this from somewhere else? do we require users to fetch these things from storage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default SIWX implementation uses local storage to store session data. As SIWX stays stateless for AppKit the would be up for the dapp to get the SIWX session. Maybe we could expose some kind of util for when using the LocalStorage implementation of SIWX, do you think is it worth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants