-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: laboratory add siwx status #3451
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
…laboratory-add-siwx-status
Coverage Report
File CoverageNo changed files found. |
|
||
useEffect(() => { | ||
const interval = setInterval(() => { | ||
const newStatus = localStorage.getItem(localStorageKey) || '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not get this from somewhere else? do we require users to fetch these things from storage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default SIWX implementation uses local storage to store session data. As SIWX stays stateless for AppKit the would be up for the dapp to get the SIWX session. Maybe we could expose some kind of util for when using the LocalStorage implementation of SIWX, do you think is it worth?
Description
Adds SIWX status in laboratory.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist