refactor: clean up and reuse wallet connect connector #3619
Conversation
🦋 Changeset detectedLatest commit: dfb8ae6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| protected caipNetworks: CaipNetwork[] | ||
|
|
||
| constructor({ provider, caipNetworks, namespace }: WalletConnectConnector.Options<Namespace>) { | ||
| this.caipNetworks = caipNetworks |
There was a problem hiding this comment.
I've seen you populate this with namespace scoped chains. Won't that have issues? WC session has all of the namespaces combined
There was a problem hiding this comment.
namespace is a mandatory key of Connector interface. I don't think it will have a problem because still each adapter have a WalletConnectConnect with its own namespace. If this would be a problem than we would need to set a kind of Connector that combines namespaces.
There was a problem hiding this comment.
I mean we'd need to triple check how chain switching is working. I'd assume that my WC connector has all the namespaces available not jsut the ones scoped to the current adapter (since I can switch to a diff namespace=
…or/clean-up-wc-connector
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist