Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet button vanilla js #3640

Merged
merged 11 commits into from
Jan 16, 2025
Merged

feat: wallet button vanilla js #3640

merged 11 commits into from
Jan 16, 2025

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Jan 14, 2025

Description

Added createAppKitWalletButton function to @reown/appkit-wallet-button package for easier implementation of the Wallet Button feature without relying solely on hooks.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2025

Showcase (Optional)

wallet-button-vanilla-js.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Jan 14, 2025

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 291ce65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-wallet-button Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:49am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:49am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Jan 16, 2025 9:49am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jan 16, 2025 9:49am
vue-wagmi-example ⬜️ Ignored (Inspect) Jan 16, 2025 9:49am

@magiziz magiziz force-pushed the feat/wallet-button-vanilla-js branch from 43649aa to 06b9af3 Compare January 14, 2025 23:08
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 66.69% 18966 / 28439
🔵 Statements 66.69% 18966 / 28439
🔵 Functions 57.85% 1660 / 2869
🔵 Branches 78.87% 3225 / 4089
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/wallet-button/src/client.ts 92.1% 83.33% 100% 92.1% 26-27, 42
Generated in workflow #8939 for commit 291ce65 by the Vitest Coverage Report Action

Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magiziz magiziz deleted the feat/wallet-button-vanilla-js branch January 16, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants