refactor: remove onUri callbacks in favor of adding single callback listener #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8da7395 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
magiziz
approved these changes
Jan 16, 2025
tomiir
reviewed
Jan 16, 2025
Comment on lines
+1292
to
+1295
| this.universalProvider.on( | ||
| 'display_uri', | ||
| ConnectionController.setUri.bind(ConnectionController) | ||
| ) |
There was a problem hiding this comment.
does this override other display_uri handlers if subscribed from outside of appkit? in the case they provide the UP externally they can self-manage
There was a problem hiding this comment.
I think if this would override an external callback, any other of the setters on display_uri we had would do the same. Do you think previously of this change this would not happen? I'm not sure about this one
tomiir
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is removing all
onUricallback drilling for allwalletConnectConnectmethods in favor of a single call when initializing the UniversalProvider.Type of change
Associated Issues
For Linear issues: Closes APKT-1826
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist