Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable/disable auth options dynamically #3721

Merged
merged 80 commits into from
Jan 22, 2025

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jan 22, 2025

Description

Fixes an state listening issue where isEmailEnabled also dependent to noAdapters state and only updating features doesn't update the isEmailEnabled if noAdapters not changes.

This can be reproducible on demo.reown.com where we have toggling email. Currently, toggling email doesn't work.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

tomiir and others added 30 commits December 20, 2024 11:29
Copy link

linear bot commented Jan 22, 2025

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: b6880c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-core Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 9:27am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 9:27am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Jan 22, 2025 9:27am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jan 22, 2025 9:27am
vue-wagmi-example ⬜️ Ignored (Inspect) Jan 22, 2025 9:27am

Base automatically changed from enes/apkt-1853-add-namespace-configuration to main January 22, 2025 09:01
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.24% 19599 / 28717
🔵 Statements 68.24% 19599 / 28717
🔵 Functions 59.5% 1718 / 2887
🔵 Branches 79.91% 3490 / 4367
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-connect-view/index.ts 82.15% 83.01% 84.21% 82.15% 63-65, 68, 72, 91, 138-139, 148, 182, 196, 207, 246, 250, 262, 273, 287-288, 291-292, 302, 323-324, 336, 347, 354-355, 360-384, 394-395, 398-399
Generated in workflow #9097 for commit b6880c5 by the Vitest Coverage Report Action

@tomiir tomiir merged commit eade9f2 into main Jan 22, 2025
19 checks passed
@tomiir tomiir deleted the enes/apkt-2099-email-toggle-button-doesnt-work branch January 22, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants