Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppliers Functionality not Working #128

Closed
JamesLPearson opened this issue Mar 20, 2023 · 1 comment · Fixed by #130
Closed

Suppliers Functionality not Working #128

JamesLPearson opened this issue Mar 20, 2023 · 1 comment · Fixed by #130
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@JamesLPearson
Copy link

Hi Mike, another strange one since the big changes. The suppliers section in the inventory doesn't appear to be working for me. I used to be able to add a URL for a supplier and cost and it looks like this has changed to a table to allow multiple suppliers (great!) but the table doesn't seem to have a way for me to add to it. Nor does it show existing suppliers I've added to items.

It just loads up like this:
Suppliers

Is this an upcoming feature that hasn't been fully implemented yet? Or has something gone wrong?

@replaysMike
Copy link
Owner

I think this also needs to take into consideration new data. The suppliers information comes from the Swarm/DigiKey/Mouser apis, so if any are disabled that data isn't going to be displayed. However, since the old data is there I can certainly integrate it into the results. I can also add an option to add results manually with an Add button, but I'll need to add some schema for that to take place. I'll try to incorporate this into the next release, but this one may get bumped to the following release.

@replaysMike replaysMike self-assigned this Mar 20, 2023
@replaysMike replaysMike added bug Something isn't working enhancement New feature or request labels Mar 20, 2023
@replaysMike replaysMike added this to the v2.3.1 milestone Mar 20, 2023
replaysMike added a commit that referenced this issue Mar 21, 2023
adds support for manually adding supplier entries
@replaysMike replaysMike added the in-progress This ticket is currently being worked on label Mar 21, 2023
@replaysMike replaysMike mentioned this issue Mar 21, 2023
@replaysMike replaysMike removed the in-progress This ticket is currently being worked on label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants