Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part scans in add bulk inventory but fails in single part scan #132

Closed
TWM617 opened this issue Mar 23, 2023 · 19 comments · Fixed by #140, #144 or #148
Closed

Part scans in add bulk inventory but fails in single part scan #132

TWM617 opened this issue Mar 23, 2023 · 19 comments · Fixed by #140, #144 or #148
Assignees
@replaysMike
Labels
bug Something isn't working
Milestone
v2.3.4

Comments

@TWM617
Copy link

TWM617 commented Mar 23, 2023

When I scan to add a single part it fails 5 times in a row. I then scan the same part in bulk add and it succeeds 5 times in a row. Not sure why there is a difference.
IMG_1339
@replaysMike
Copy link
Owner

indeed it should work in both - are you on the latest v2.3.1? I'll try it myself and see if I can repro it

@replaysMike replaysMike self-assigned this Mar 23, 2023
@replaysMike replaysMike added the bug Something isn't working label Mar 23, 2023
@TWM617
Copy link
Author

TWM617 commented Mar 23, 2023

Yep, 2.3.1.

@replaysMike replaysMike added the in-progress This ticket is currently being worked on label Mar 28, 2023
@replaysMike
Copy link
Owner

I think I found the problem here. It seems sometimes it fails to decode the barcode, and sends the raw barcode string to the api which is incorrect. Should be able to fix this and include in today's release

@replaysMike replaysMike added this to the v2.3.2 milestone Mar 28, 2023
replaysMike added a commit that referenced this issue Mar 28, 2023
@replaysMike
fixes #132 - reworked scanner input so it doesn't swallow function ke…
cf1a3dc 
…ys, and copy/paste. Also reworked inventory page barcode requests so it is consistent in bulk scan.

added BOM csv export option.
additional BOM features added.
@replaysMike replaysMike mentioned this issue Mar 28, 2023
Merged
@TWM617
Copy link
Author

TWM617 commented Mar 29, 2023

This problem is not fixed.

The result of a scan in Part Invertory scan:
Ashampoo_Snap_Wednesday, March 29, 2023_09h11m08s_006_

The result from a bulk scan:
Ashampoo_Snap_Wednesday, March 29, 2023_09h12m08s_007_

@replaysMike
Copy link
Owner

Looking into this again today, I'm suspecting an MS Edge difference from Chrome, which would be weird as they are both based on Chromium. They keyboard handling is complex, but I did a bunch of work to make both use the same code but some of it relies on how the browser handles keyboard input. I'll let you know shortly

@replaysMike replaysMike reopened this Mar 29, 2023
@TWM617
Copy link
Author

TWM617 commented Mar 29, 2023

Given your reference to Chrome, I thought perhaps it was a short term workaround so I could get moving but I tried it and see the same error. Note that the end of the following error message (like the one in the capture I previously posted) are characters from the last thing I typed or copied which are appended to the error message which apparently was sent in the request message:

Ashampoo_Snap_Wednesday, March 29, 2023_11h44m23s_004_

@replaysMike replaysMike modified the milestones: v2.3.2, v2.3.3 Mar 30, 2023
@replaysMike
Copy link
Owner

I'm still retesting this one. I'm not sure if it's a difference of keyrate, or if there is a timing issue somewhere. It looks like somehow it's getting through the barcode input scanning module completely, and it's trying to search that as a part number. As if the text went right to the search input and didn't get filtered like its supposed to. Will keep plugging away at it

@TWM617
Copy link
Author

TWM617 commented Mar 30, 2023 via email

@replaysMike
Copy link
Owner

This issue has been handed off to DigiKey support for the moment, there's something funny about this part label as there are extra GS & RS characters at the end that shouldn't be there. I'm going to try and make an update to prevent this from coming out this way, but it's failing to be translated by the DigiKey 2d barcode API.

@replaysMike
Copy link
Owner

@TWM617 can you reply to this message and scan that barcode on your end into the message? I don't know if it's just the way the message is displayed in that No part information banner, or if your scanner is outputting some of the characters a little different. I noticed the third character is a triangle '▲', when it should be a '>' character. This might be the cause of the funny output that I can't trigger over here - DigiKey api issue aside.

replaysMike added a commit that referenced this issue Mar 31, 2023
@replaysMike
an attempt to try and detect problematic part labels, for fixing #132
1cb12f2
@TWM617
Copy link
Author

TWM617 commented Mar 31, 2023 via email

@replaysMike
Copy link
Owner

The part I don’t understand is that Bulk Inventory adds work flawlessly. Well anyway, here it is:

I don't understand it either. There are 2 code paths for the behavior, but they are almost entirely the same. Need to find a way to repro it on my end

replaysMike added a commit that referenced this issue Mar 31, 2023
@replaysMike
Fixes #132 - Hopefully a permanent fix for invalid part labels, and p…
6fa88cf 
…assing barcode scans to the part info endpoint
@replaysMike replaysMike mentioned this issue Apr 1, 2023
Merged
replaysMike added a commit that referenced this issue Apr 1, 2023
@replaysMike
an attempt to try and detect problematic part labels, for fixing #132
c505380
@TWM617
Copy link
Author

TWM617 commented Apr 2, 2023

I hate to say it but this problem still exists. Scans perfectly in bulk add scan but fails in single part add scan. The error message for single part scan is different now but the submit to Digikey still fails.

The scan error message returns this:

No part information is available for '[)▲06↔J2DA5B02E.F7714D73.93C6D152.7F652D6B5032↔PAZ1117EH-3.3TRG1DICT-ND↔1PAZ1117EH-3.3TRG1↔9D1719↔14Z170507↔1TH510592.U1↔4LCN↔11ZPREPACK↔15Z1.0.1↔12Z5001336↔Q000000001↔13Z000000↔▲'.

Barcode scanner test returns this:

{
"type": "datamatrix",
"value": {
"description": "AZ1117EH-3.3TRG1DICT-ND",
"mfgPartNumber": "AZ1117EH-3.3TRG1",
"countryOfOrigin": "CN",
"pick": "PREPACK",
"partId": "5001336",
"quantity": 1,
"loadId": "000000\u001eV\r"
},
"correctedValue": "[)>\u001e06\u001dJ2DA5B02E.F7714D73.93C6D152.7F652D6B5032\u001dPAZ1117EH-3.3TRG1DICT-ND\u001d1PAZ1117EH-3.3TRG1\u001d9D1719\u001d14Z170507\u001d1TH510592.U1\u001d4LCN\u001d11ZPREPACK\u001d15Z1.0.1\u001d12Z5001336\u001dQ000000001\u001d13Z000000\u001eV\r",
"rawValue": "[)>\u001e06\u001dJ2DA5B02E.F7714D73.93C6D152.7F652D6B5032\u001dPAZ1117EH-3.3TRG1DICT-ND\u001d1PAZ1117EH-3.3TRG1\u001d9D1719\u001d14Z170507\u001d1TH510592.U1\u001d4LCN\u001d11ZPREPACK\u001d15Z1.0.1\u001d12Z5001336\u001dQ000000001\u001d13Z000000\u001eV\r",
"rsDetected": true,
"gsDetected": true,
"eotDetected": false,
"invalidBarcodeDetected": false,
"rawValueFormatted": "[)>␞06␝J2DA5B02E.F7714D73.93C6D152.7F652D6B5032␝PAZ1117EH-3.3TRG1DICT-ND␝1PAZ1117EH-3.3TRG1␝9D1719␝14Z170507␝1TH510592.U1␝4LCN␝11ZPREPACK␝15Z1.0.1␝12Z5001336␝Q000000001␝13Z000000␞V\r"

@replaysMike replaysMike reopened this Apr 2, 2023
@replaysMike
Copy link
Owner

I'm not giving up on this issue. Interesting. This barcode wasn't detected as invalid even though it does on my barcode scanner. I see an extra RS character that's on the end, but it's missing the extra GS character shown on my barcode scanner. Will plug away at this again as the priority issue.

@TWM617
Copy link
Author

TWM617 commented Apr 2, 2023 via email

@replaysMike
Copy link
Owner

replaysMike commented Apr 2, 2023 via email

@replaysMike replaysMike modified the milestones: v2.3.3, v2.3.4 Apr 3, 2023
replaysMike pushed a commit that referenced this issue Apr 3, 2023
Fixes #132 - hopefully for the last time. Corrects badly formed datam…
00f597b 
…atrix barcodes with invalid RS/GS encoding
@replaysMike replaysMike mentioned this issue Apr 3, 2023
Merged
replaysMike pushed a commit that referenced this issue Apr 3, 2023
@replaysMike
Fixes #132 - hopefully for the last time. Corrects badly formed datam…
a8d497d 
…atrix barcodes with invalid RS/GS encoding
@replaysMike replaysMike removed the in-progress This ticket is currently being worked on label Apr 4, 2023
@replaysMike
Copy link
Owner

Hoping that v2.3.4 fixes this issue for good :)

@TWM617
Copy link
Author

TWM617 commented Apr 4, 2023 via email

@replaysMike
Copy link
Owner

No prob, glad we finally got it. If you run into any more problematic labels let me know. Going to scan in some mouser and arrow stuff this week, hopefully those are easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@replaysMike replaysMike

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.3.4
2 participants
@replaysMike @TWM617