Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Problems deleting/replacing user files #232

Closed
parzival opened this issue Jul 20, 2023 · 2 comments · Fixed by #263
Closed

[Bug]: Problems deleting/replacing user files #232

parzival opened this issue Jul 20, 2023 · 2 comments · Fixed by #263
Assignees
Labels
bug Something isn't working
Milestone

Comments

@parzival
Copy link

Binner version

2.6.0

Operating System

Ubuntu 20.04

Describe the bug and the steps to reproduce it

It appears that the 'delete file' button is not functional, at least for datasheets. Creating a part and uploading a datasheet works okay, and the file is correctly placed in the [User Files]/Datasheets directory. However, the red x 'delete' button does not appear to work in Firefox 113 for MacOS, nor in Safari 16.3.

Potentially more of an issue is that replacing the file (by dragging a new file) does bring up the dialog box to delete the existing file. If the deletion is confirmed, the new file apparently updates, although the filename listed was incorrect until I leave the page and come back. However, the new file does not load (giving the 404 JSON data instead when clicking on the datasheet preview). It seems to be uploading the new file before deleting the old one, as when I do this, the [User Files] directory has a file with the name PN-Datasheet-1.pdf, which is likely why it cannot load it. Replacing the file a second time works (this is likely because it uploaded it to PN-Datasheet.pdf, as that file was not currently in the directory).

Also, a feature request would be to show a dialog or better error message if the file cannot be found, instead of the JSON error data.

(I placed brackets around [User Files] as my settings have changed this from the default. I would hope that does not cause this problem, but it could be a reason.)

Would you like to attach your appsetings.json configuration?

No response

Screenshots or Videos (Optional, but they help!)

No response

Are you able to contribute a PR? (No is ok!)

None

@Lucard-AUT
Copy link

I was able to delete an attached datasheet by doing the following two steps:

  • Clicking on the delete button (red X). (Nothing happens since the button is somewhat broken)
  • Clicking in the Part-field and writing something.

Then the delete-dialog appears and i can click "OK", the datasheet is deleted.
Also the "cancel"-button on tis dialog is not working

Tested on Win10, Binner v2.6.0

@replaysMike replaysMike added this to the v2.6.3 milestone Apr 8, 2024
@replaysMike replaysMike self-assigned this Apr 8, 2024
@replaysMike replaysMike added the in-progress This ticket is currently being worked on label Apr 8, 2024
@replaysMike
Copy link
Owner

Issue is fixed, will appear in v2.6.3

@replaysMike replaysMike removed the in-progress This ticket is currently being worked on label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants