Resolve or ignore Ruff and Pylint warnings #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
commented
Jul 25, 2024
mattt
commented
Jul 25, 2024
mattt
commented
Jul 25, 2024
| @@ -518,17 +521,18 @@ def train( | |||
| if name == "TrainingOutput": | |||
| return TrainingOutputType | |||
|
|
|||
| if name == "Output": | |||
| if name == "Output": # pylint: disable=no-else-return | |||
There was a problem hiding this comment.
Worth calling out that the else is used here to avoid a warning about redefinition of TrainingOutput.
mattt
commented
Jul 25, 2024
Comment on lines
-27
to
+30
| f"Failed to create cog runtime state directory ({self._root}). " | ||
| "Failed to create cog runtime state directory (%s). " | ||
| "Does it already exist and is a file? Does the user running cog " | ||
| "have permissions?" | ||
| "have permissions?", | ||
| self._root, |
There was a problem hiding this comment.
Flagging this as a nontrivial change.
mattt
commented
Jul 25, 2024
| from requests.packages.urllib3.util.retry import Retry # type: ignore | ||
| from urllib3.util.retry import Retry |
There was a problem hiding this comment.
mattt
commented
Jul 25, 2024
mattt
commented
Jul 25, 2024
…consider-using-with)
…se your program to hang indefinitely (missing-timeout)
…nt the code inside it (no-else-return)
…se your program to hang indefinitely (missing-timeout)
…consider-using-with)
…t the code inside it (no-else-raise)
…lif (no-else-break)
…ttribute-defined-outside-init)
…ot overridden in child class 'ConcatenateIterator' (abstract-method)
…n expression, or none of them should. (inconsistent-return-statements)
…ecified-encoding)
…lif (no-else-raise)
…consider-using-with)
…sed_url.scheme in ('http', 'https')'. Use a set instead if elements are hashable. (consider-using-in)
…elif (no-else-return)
…he code inside it (no-else-return)
…ecified-encoding)
…nt the code inside it (no-else-return)
…ng style (invalid-name)
…ne. (invalid-envvar-default)
…elif (no-else-return)
mattt
force-pushed
the
mattt/fix-pylint-warnings
branch
from
49b241b to
9078eb2
Compare
mattt
changed the title
|
are we using both pylint and ruff now? |
@technillogue Yes. And Pyright, too. Taking a belt and suspenders and chainmail approach, I suppose. |
mattt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring warnings related to
TODOandFIXMEcomments:This is a lot, but I think it would help us to ratchet up code quality ahead of merging async.