Handle CUDA version modifiers on torch #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If we get given a torch with a cuda version modifier such as 2.0.3+cu118 we fail if we do not explicitly support this version. * Instead extract the CUDA version from the version tag (11.8) and perform our cuda compatibility lookup with those 2 versions.
Signed-off-by: Will Sackfield <sackfield@replicate.com>
mattt
reviewed
Aug 15, 2024
mattt
reviewed
Aug 15, 2024
Co-authored-by: Mattt <mattt@replicate.com> Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Co-authored-by: Mattt <mattt@replicate.com> Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly support this version.
compatibility lookup with those 2 versions.
Fixes: #1867