Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install apt packages before pip packages #1954

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Install apt packages before pip packages #1954

merged 2 commits into from
Sep 13, 2024

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Sep 13, 2024 •
edited
Loading

  • Moves apt installs to just below the initial FROM line
  • This prevents pip packages not installing due to depending on these apt packages

Fixes: #1949

@8W9aG
Install apt packages before pip packages
75f06c9 
* Moves apt installs to just below the initial
FROM line
* This prevents pip packages not installing due to
depending on these apt packages
mattt
mattt approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @8W9aG.

I love this improvement. I don't love what's needed to get there. (And I'm sure you're also not super jazzed about pipInstallStage take aptInstalls as an argument).

How we generate Dockerfiles is long overdue for a rethink. I don't believe we have the appetite to pick that up anytime soon, so I'm fine to hold my nose on this one.

@8W9aG
Copy link
Contributor Author

8W9aG commented Sep 13, 2024

Thanks, @8W9aG.

I love this improvement. I don't love what's needed to get there. (And I'm sure you're also not super jazzed about pipInstallStage take aptInstalls as an argument).

How we generate Dockerfiles is long overdue for a rethink. I don't believe we have the appetite to pick that up anytime soon, so I'm fine to hold my nose on this one.

In this case if we removed the separate weights stuff I think we could come up with a very decent dockerfile generator which was more declarative than procedural.

@8W9aG 8W9aG merged commit 03b4077 into main Sep 13, 2024
15 checks passed
@8W9aG 8W9aG deleted the install-apt-before-pip branch September 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattt mattt mattt approved these changes

@andreasjansson andreasjansson Awaiting requested review from andreasjansson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install packages before pip install
2 participants
@8W9aG @mattt