Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test failing on Node 20 #237

Closed
zeke opened this issue Apr 9, 2024 · 0 comments · Fixed by #239
Closed

npm test failing on Node 20 #237

zeke opened this issue Apr 9, 2024 · 0 comments · Fixed by #239

Comments

@zeke
Copy link
Member

zeke commented Apr 9, 2024

Node.js 20 npm test used to pass, but are now failing as of Node.js v20.12.1

I can reproduce this locally on macOS with Node v20.12.1

Tests still pass on GitHub Actions running Node 18.

https://github.com/replicate/replicate-javascript/actions/runs/8622382600/job/23635903834?pr=236#step:5:16

TypeError: Cannot assign to read only property 'fetch' of object '[object global]'

    7 |   parseProgressFromLogs,
    8 | } from "replicate";
 >  9 | import nock from "nock";
      | ^
   10 | import { Readable } from "node:stream";
   11 | import { createReadableStream } from "./lib/stream";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant